chore: Switch to @tony.ganchev/eslint-plugin-header#38
Merged
NathanZlion merged 1 commit intocloudscape-design:mainfrom Mar 20, 2026
Merged
chore: Switch to @tony.ganchev/eslint-plugin-header#38NathanZlion merged 1 commit intocloudscape-design:mainfrom
NathanZlion merged 1 commit intocloudscape-design:mainfrom
Conversation
Hi, team, I noticed you are using _eslint-plugin-header_ on ESLint 8. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to add support for ESLint 9 and hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin and have been doing so for the last two years. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - many other bug-fixes. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. I've sent PR proposals to other projects in the _cloudscape-design_ space: - cloudscape-design/board-components#401 - cloudscape-design/browser-test-tools#188 - cloudscape-design/chart-components#185 - cloudscape-design/code-view#122 - cloudscape-design/collection-hooks#136 - cloudscape-design/component-toolkit#200 - cloudscape-design/components#4308 - cloudscape-design/demos#243 - cloudscape-design/documenter#112 - cloudscape-design/global-styles#73 - cloudscape-design/jest-preset#58 - cloudscape-design/test-utils#114 - cloudscape-design/theming-core#148 Looking forward to your feedback.
This was referenced Mar 16, 2026
NathanZlion
changed the title
Contributor
Author
|
@NathanZlion - the codecov failure should be unrelated to my change. Can you help troubleshoot? I think I saw other failures in different linked PRs. Thanks! |
NathanZlion
approved these changes
Mar 19, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
cloudscape-design:main
with commit Mar 20, 2026
513f4b1
122 of 126 checks passed
Contributor
Author
|
ecosystem test for this and other cloudscape project: tonyganchev/eslint-plugin-header#163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, team,
I noticed you are using eslint-plugin-header on ESLint 8.
I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support
for ESLint 9 and hoped it would be a temporary measure but since the
original has not been updated for five years I decided to continue
improving the new plugin and have been doing so for the last two years.
Specific improvements include:
@jest-environment.I've sent PR proposals to other projects in the cloudscape-design
space:
Looking forward to your feedback.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.