crt: fix strict Pyright type checking errors#56
Open
UweSchwaeke wants to merge 2 commits intoclyso:mainfrom
Conversation
* what Assigned unused return values from `git_prepare_remote` and `git_push` to the discard variable `_` in `manifest.py`. Added a `typing.cast` to `Callable[..., str]` for `repo.git.ls_remote` in `git_utils.py`. * why To resolve `reportUnusedCallResult` and `reportAny` errors flagged by stricter Pyright configurations. This explicitly acknowledges intentionally ignored return values and prevents untyped `Any` values from leaking out of the GitPython library, keeping the codebase strictly typed. Co-authored-by: Gemini <gemini@google.com> Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
To resolve `reportUnusedCallResult` errors flagged by stricter Pyright configurations. This explicitly acknowledges intentionally ignored return values. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
UweSchwaeke
force-pushed
the
55-fix-pyright-strictness-errors-reportunusedcallresult-and-reportany-in-manifestpy-and-git_utilspy
branch
from
fca0715 to
daea3cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what Assigned unused return values from
git_prepare_remoteandgit_pushto the discard variable_inmanifest.py. Added atyping.casttoCallable[..., str]forrepo.git.ls_remoteingit_utils.py.why To resolve
reportUnusedCallResultandreportAnyerrors flagged by stricter Pyright configurations. This explicitly acknowledges intentionally ignored return values and prevents untypedAnyvalues from leaking out of the GitPython library, keeping the codebase strictly typed.see Ticket #55