Skip to content

crt: fix strict Pyright type checking errors #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UweSchwaeke wants to merge 2 commits into
base: main
Choose a base branch
from
Open

crt: fix strict Pyright type checking errors #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91b58c
crt: fix strict Pyright type checking errors
UweSchwaeke Mar 17, 2026
daea3cf
cbscore: fix strict Pyright type checking errors
UweSchwaeke Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cbscore/src/cbscore/images/signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def _get_signing_params(

def can_sign(registry: str, secrets: SecretsMgr, transit: str) -> bool:
try:
_get_signing_params(registry, secrets, transit)
_ = _get_signing_params(registry, secrets, transit)
except SigningError as e:
logger.debug(e.msg)
return False
Expand Down
8 changes: 4 additions & 4 deletions crt/src/crt/cmds/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,15 +1171,15 @@ def _prepare_release_repo(
release = load_release(ces_patch_path, release_name)
release_repo_name = release.base_repo

git_prepare_remote(
_ = git_prepare_remote(
ceph_repo_path, f"github.com/{release_repo_name}", release_repo_name, token
)
if remote_name != release_repo_name:
git_prepare_remote(
_ = git_prepare_remote(
ceph_repo_path, f"github.com/{remote_name}", remote_name, token
)
git_push(ceph_repo_path, release_branch_name, remote_name)
git_push(ceph_repo_path, release_tag_name, remote_name)
_ = git_push(ceph_repo_path, release_branch_name, remote_name)
_ = git_push(ceph_repo_path, release_tag_name, remote_name)
except GitError as e:
perror(f"unable to prepare release repository: {e}")
sys.exit(e.ec if e.ec else errno.ENOTRECOVERABLE)
6 changes: 3 additions & 3 deletions crt/src/crt/crtlib/git_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import re
import sys
import tempfile
from collections.abc import Callable
from pathlib import Path
from typing import cast, override

Expand Down Expand Up @@ -814,9 +815,8 @@ def git_format_patch(repo_path: Path, rev: SHA, *, base_rev: SHA | None = None)
def git_tag_exists_in_remote(repo_path: Path, remote_name: str, tag_name: str) -> bool:
try:
repo = git.Repo(repo_path)
raw_tag: str = repo.git.ls_remote(
"--tags", remote_name, f"refs/tags/{tag_name}"
)
ls_remote = cast(Callable[..., str], repo.git.ls_remote)
raw_tag: str = ls_remote("--tags", remote_name, f"refs/tags/{tag_name}")
return bool(raw_tag.strip())
except git.CommandError as e:
msg = f"unable to execute git ls-remote --tags {remote_name} refs/tags/{tag_name}: {e}"
Expand Down