Skip to content

rename test image name for onboarding to cirros-kvm#255

Merged
notandy merged 1 commit intomainfrom
rename-test-image-name
Mar 9, 2026
Merged

rename test image name for onboarding to cirros-kvm#255
notandy merged 1 commit intomainfrom
rename-test-image-name

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Mar 6, 2026

is maybe more desirable than expose a D-number to the world.
also improve error messages a bit.

should be suceeded by openstack image set --name cirros-kvm cirros-d240801-kvm in QA

@notandy notandy force-pushed the rename-test-image-name branch from 21981e3 to 70c3010 Compare March 6, 2026 19:34
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 61.16% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 55.20% (ø) 250 138 112

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go

@notandy notandy requested a review from fwiesel March 9, 2026 14:14
@notandy notandy merged commit 9c8ed61 into main Mar 9, 2026
6 checks passed
@notandy notandy deleted the rename-test-image-name branch March 9, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants