Skip to content

rename test image name for onboarding to cirros-kvm #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notandy merged 1 commit into from
Mar 9, 2026
Merged

rename test image name for onboarding to cirros-kvm #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/controller/onboarding_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const (
defaultWaitTime = 1 * time.Minute
testProjectName = "test"
testDomainName = "cc3test"
testImageName = "cirros-d240801-kvm"
testImageName = "cirros-kvm"
testPrefixName = "ohooc-"
testVolumeType = "kvm-pilot"
OnboardingControllerName = "onboarding"
Expand Down Expand Up @@ -236,7 +236,7 @@ func (r *OnboardingController) smokeTest(ctx context.Context, hv *kvmv1.Hypervis
zone := hv.Labels[corev1.LabelTopologyZone]
server, err := r.createOrGetTestServer(ctx, zone, host, hv.UID)
if err != nil {
return ctrl.Result{}, fmt.Errorf("failed to create or get test instance %w", err)
return ctrl.Result{}, fmt.Errorf("failed to create or get test instance: %w", err)
}

switch server.Status {
Expand Down Expand Up @@ -504,7 +504,7 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,

imageRef, err := r.findTestImage(ctx)
if err != nil {
return nil, fmt.Errorf("could not list networks due to %w", err)
return nil, fmt.Errorf("could not list networks: %w", err)
}

networkRef, err := r.findTestNetwork(ctx)
Expand Down Expand Up @@ -580,7 +580,7 @@ func (r *OnboardingController) findTestImage(ctx context.Context) (string, error
}
}

return "", errors.New("couldn't find image")
return "", fmt.Errorf("couldn't find image with name %v", testImageName)
}

func (r *OnboardingController) findTestFlavor(ctx context.Context) (string, error) {
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/onboarding_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ var _ = Describe("Onboarding Controller", func() {
"images": [
{
"status": "active",
"name": "cirros-d240801-kvm",
"name": "cirros-kvm",
"tags": [],
"container_format": "bare",
"created_at": "2014-11-07T17:07:06Z",
Expand Down