feat(cli): add additionalIdls config option#1018
Open
plutohan wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: c083e61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mikhd
reviewed
Jul 6, 2026
| additionalPrograms.push(...getAllPrograms(additionalRootNode)); | ||
| } | ||
|
|
||
| return rootNode(mainRootNode.program, additionalPrograms); |
Contributor
There was a problem hiding this comment.
I think the version could be lost here. (worth checking other fields as well)
getRootNodeFromIdl returns a RootNode one of two ways:
- If the IDL already is a Codama root node, it returns it as-is, preserving the whatever specified version.
- Otherwise it's an Anchor IDL, and
rootNodeFromAnchor(idl)builds a root node via therootNode().
mikhd
reviewed
Jul 6, 2026
| const parsed = await getParsedConfig({}); | ||
|
|
||
| expect(parsed.rootNode.program.name).toBe('main'); | ||
| expect(parsed.rootNode.additionalPrograms.map(p => p.name)).toEqual(['a', 'b']); |
Contributor
There was a problem hiding this comment.
I would double check that version and other fields are preserved after additionalPrograms merge.
Thank you!
Author
|
Good catch, the merge rebuilt the root node and reset version and standard. It now spreads the main root node instead, with test assertions for both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #983.
Implements the
additionalIdlsapproach from your comment @lorisleiva: the config can list additional Anchor IDLs, and their programs get merged into the root node'sadditionalPrograms, so onecodama.jsongenerates clients for every program in an Anchor workspace.Includes a README entry, a test, and a changeset.