-
Notifications
You must be signed in to change notification settings - Fork 85
feat(cli): add additionalIdls config option #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
plutohan
wants to merge
2
commits into
codama-idl:main
Choose a base branch
from
plutohan:plutohan/issue-983-additional-idls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@codama/cli': minor | ||
| --- | ||
|
|
||
| Add an `additionalIdls` config option to generate clients for multiple programs in an Anchor workspace from a single `codama.json` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import type { ProgramNode, RootNode } from '@codama/nodes'; | ||
| import { beforeEach, expect, test, vi } from 'vitest'; | ||
|
|
||
| import { getConfig } from '../src/config'; | ||
| import { getParsedConfig } from '../src/parsedConfig'; | ||
| import { importModuleItem } from '../src/utils/import'; | ||
| import { getRootNodeFromIdl } from '../src/utils/nodes'; | ||
|
|
||
| vi.mock('../src/config', () => ({ getConfig: vi.fn() })); | ||
| vi.mock('../src/utils/import', () => ({ importModuleItem: vi.fn() })); | ||
| vi.mock('../src/utils/nodes', () => ({ getRootNodeFromIdl: vi.fn() })); | ||
|
|
||
| const getConfigMock = vi.mocked(getConfig); | ||
| const importModuleItemMock = vi.mocked(importModuleItem); | ||
| const getRootNodeFromIdlMock = vi.mocked(getRootNodeFromIdl); | ||
|
|
||
| function programNode(name: string): ProgramNode { | ||
| return { | ||
| accounts: [], | ||
| constants: [], | ||
| definedTypes: [], | ||
| errors: [], | ||
| instructions: [], | ||
| kind: 'programNode', | ||
| name, | ||
| pdas: [], | ||
| } as unknown as ProgramNode; | ||
| } | ||
|
|
||
| function rootNodeWith(name: string): RootNode { | ||
| return { | ||
| additionalPrograms: [], | ||
| kind: 'rootNode', | ||
| program: programNode(name), | ||
| standard: 'codama', | ||
| version: '1.0.0', | ||
| } as unknown as RootNode; | ||
| } | ||
|
|
||
| beforeEach(() => { | ||
| vi.resetAllMocks(); | ||
| importModuleItemMock.mockResolvedValue({}); | ||
| }); | ||
|
|
||
| test('merges additionalIdls programs into the root node additionalPrograms', async () => { | ||
| getConfigMock.mockResolvedValue([{ additionalIdls: ['a.json', 'b.json'], idl: 'main.json' }, '/root/codama.json']); | ||
| getRootNodeFromIdlMock | ||
| .mockResolvedValueOnce({ ...rootNodeWith('main'), version: '9.9.9' } as RootNode) | ||
| .mockResolvedValueOnce(rootNodeWith('a')) | ||
| .mockResolvedValueOnce(rootNodeWith('b')); | ||
|
|
||
| const parsed = await getParsedConfig({}); | ||
|
|
||
| expect(parsed.rootNode.program.name).toBe('main'); | ||
| expect(parsed.rootNode.additionalPrograms.map(p => p.name)).toEqual(['a', 'b']); | ||
| // The main root node's other fields are preserved by the merge. | ||
| expect(parsed.rootNode.standard).toBe('codama'); | ||
| expect(parsed.rootNode.version).toBe('9.9.9'); | ||
| }); | ||
|
|
||
| test('leaves the root node unchanged when no additionalIdls are provided', async () => { | ||
| getConfigMock.mockResolvedValue([{ idl: 'main.json' }, '/root/codama.json']); | ||
| getRootNodeFromIdlMock.mockResolvedValue(rootNodeWith('main')); | ||
|
|
||
| const parsed = await getParsedConfig({}); | ||
|
|
||
| expect(parsed.rootNode.additionalPrograms).toEqual([]); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check that
versionand other fields are preserved afteradditionalProgramsmerge.Thank you!