Merged
Conversation
Signed-off-by: Matthew DeVenny <matt@codecargo.com>
There was a problem hiding this comment.
Pull request overview
Adds a job identifier to the audit summary/API push flow so results can be correlated back to the specific GitHub Actions job/check run (Issue #38).
Changes:
- Introduces a new Action input
job-id(defaulting via workflow expression) for the current job’s check run ID. - Conditionally forwards that value to the
cargowall summarycommand as--job-run-id(only if the binary supports the flag). - Logs the job ID in the startup configuration output and updates bundled
dist/artifacts accordingly.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/summary.ts | Reads job-id and conditionally appends --job-run-id to the summary API push args; updates API-arg removal list. |
| src/start.ts | Logs the configured job identifier in the startup configuration group. |
| action.yml | Adds new job-id input with a default expression. |
| dist/post/index.js | Bundled output reflecting the src/summary.ts change. |
| dist/main/index.js | Bundled output reflecting the src/start.ts change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew DeVenny <matt@codecargo.com>
Signed-off-by: Matthew DeVenny <matt@codecargo.com>
Signed-off-by: Matthew DeVenny <matt@codecargo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #38
TODO:
cargowallv1.0.1setup.tsCARGOWALL_VERSIONto refer tov1.0.1--job-run-id(v1.0.1will have--job-run-id)