fix(ai): retry upstream availability failures#323
Closed
minpeter wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 24, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_unavailableprovider code as transient and retryableThis is an independent PR based directly on current
main.Reported failure
The existing classifier covered HTTP 503, service-unavailable text, network errors, and narrow WebSocket close
wording, but not the structured
upstream_unavailablecode. Without a configured fallback chain the turn thereforesettled immediately instead of entering the bounded same-model retry policy.
RED -> GREEN
true, receivedfalseauto_retry_start, received none; one provider call only\bupstream_unavailable\badmittedReal-surface QA
A local OpenAI Responses server emitted the exact
response.failedcode/message once, then a successful response.The real source CLI:
Root build and
npm run checkalso passed.Summary by cubic
Classifies the exact
upstream_unavailableprovider error as transient and retryable, so Codex upstream WebSocket send failures trigger the bounded same-model retry policy instead of failing immediately. Non-retryable cases (quota/billing, context overflow, refusals, sensitive output, and generic unknowns) remain excluded; tests validate the provider-neutral classifier and the no-fallback AgentSession path.Written for commit 8b9d28a. Summary will update on new commits.