fix(ai): retry unavailable Codex upstreams#330
Draft
minpeter wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_unavailableCodex websocket proxy failures as retryablemainwithout force-pushing historyRED -> GREEN
Error: upstream_unavailable: ... ConnectionClosedOKclassified as non-retryableValidation
packages/ai/test/retry.test.ts: 7 passedpackages/coding-agent/test/suite/retry-fallback-engine.test.ts: 10 passednpm run build: passednpm run check: passedgit diff --check: passedSupersedes #323, which was based on pre-#310 main and conflicts only in the rewritten retry fixture.
Summary by cubic
Classifies Codex
upstream_unavailablewebsocket proxy errors as transient so they retry under the existing bounded policy. Prevents immediate failure on disconnects and allows automatic recovery."upstream_unavailable"provider errors as retryable inutils/retry.ts.packages/aiandpackages/coding-agentto cover Codex websocket disconnects.Written for commit f6c3f65. Summary will update on new commits.