fix(codemode): bound eval status history#324
Closed
minpeter wants to merge 2 commits into
Closed
Conversation
This was referenced Jul 24, 2026
Contributor
Author
|
Superseded by verified current-main Draft #334. The replacement is based directly on main@38bd3a3cf, carries patch-identical minimal commits, and passed the root build/check, scoped Code Mode tests, and real 256 MB source-CLI QA at 20,000 status events. Closing this stale branch only after confirming #334 live with the verified head SHA. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is deliberately independent and based directly on current
main; it has no compaction lifecycle or TUIdependency. It supersedes the old fork-only third PR in that stack.
Root cause
Each eval cell kept every emitted status event in
state.events. Read/update-heavy child work could emit thousands ofevents, and every render rebuilt the full unbounded list. A long session could therefore retain and repeatedly render
enough history to drive V8 toward its heap limit.
Behavior
Verification
Fresh validation receipts will be attached to this Draft before it is marked ready.
Summary by cubic
Bound each eval cell’s status history in
senpi-codemodeto 100 entries to prevent unbounded growth and costly re-renders. Updated renderer, tests, and docs accordingly.status-events-omittedop (e.g., “26 earlier events omitted”).Written for commit 98e7ca6. Summary will update on new commits.