fix(codemode): bound eval status history#335
Draft
minpeter wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the clean current-
mainreplacement for #324, replayed directly ontoupstream/main@38bd3a3cfwith no compaction or TUI dependency.Root cause
Each eval cell kept every emitted status event in
state.events. Read/update-heavy child work could emit thousands of events, and every render rebuilt the full unbounded list. A long session could therefore retain and repeatedly render enough history to drive V8 toward its heap limit.Behavior
Verification
senpi-codemodesuite: 54 files / 372 tests passed; 1 file / 12 tests skippednpm run build: passednpm run check: passedNODE_OPTIONS=--max-old-space-size=256: 20,000 reads completed, 100 top-level/cell status rows retained, exact omitted count 19,901, auth unchangedgit diff --check: passedKept as Draft for maintainer review.
Summary by cubic
Bound Code Mode eval status history per cell to 100 rows to prevent unbounded growth and reduce memory pressure. Keeps the newest events and shows an exact omitted count.
status-events-omittedrow and retain the latest 99 events; the omitted count increments as more events arrive.README.md/CHANGELOG.mdand added tests for trimming and partial/final details.Written for commit 8da0cea. Summary will update on new commits.