Add checks for test.sh existence and executable permissions in build command.#4
Closed
rohitpaulk wants to merge 1 commit into
Closed
Add checks for test.sh existence and executable permissions in build command.#4rohitpaulk wants to merge 1 commit into
rohitpaulk wants to merge 1 commit into
Conversation
| } | ||
| if fileInfo.Mode()&0111 == 0 { | ||
| return handleErrorDuringBuild(build, "", fmt.Errorf("test.sh is not executable in tester dir (%s)", testerDir)) | ||
| } |
There was a problem hiding this comment.
Bug: Missing check that test.sh is a regular file
The validation checks existence and executable permissions but doesn't verify that test.sh is a regular file. If test.sh is a directory (which typically has execute bits set for traversal), the check fileInfo.Mode()&0111 == 0 passes, but attempting to execute it as a script later will fail. Adding a check like fileInfo.Mode().IsRegular() would catch this case and provide a clearer error message upfront.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds early checks ensuring
testerDir/test.shexists and is executable, with clear failure messages.builder/internal/commands/build_image_command.go):testerDir/test.shexists; return error if missing.test.shis executable; return error if not.statontest.shwith detailed messages.Written by Cursor Bugbot for commit 8bc68f6. This will update automatically on new commits. Configure here.