Skip to content

Add checks for test.sh existence and executable permissions in build command. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohitpaulk wants to merge 1 commit into from
Closed

Add checks for test.sh existence and executable permissions in build command. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions builder/internal/commands/build_image_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,18 @@ func BuildImageCommand() int {
return handleErrorDuringBuild(build, "", fmt.Errorf("tester dir (%s) does not exist", testerDir))
}

testShPath := filepath.Join(testerDir, "test.sh")
fileInfo, err := os.Stat(testShPath)
if os.IsNotExist(err) {
return handleErrorDuringBuild(build, "", fmt.Errorf("test.sh does not exist in tester dir (%s)", testerDir))
}
if err != nil {
return handleErrorDuringBuild(build, "", fmt.Errorf("failed to stat test.sh in tester dir (%s): %w", testerDir, err))
}
if fileInfo.Mode()&0111 == 0 {
return handleErrorDuringBuild(build, "", fmt.Errorf("test.sh is not executable in tester dir (%s)", testerDir))
}

@cursor cursor Bot Dec 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing check that test.sh is a regular file

The validation checks existence and executable permissions but doesn't verify that test.sh is a regular file. If test.sh is a directory (which typically has execute bits set for traversal), the check fileInfo.Mode()&0111 == 0 passes, but attempting to execute it as a script later will fail. Adding a check like fileInfo.Mode().IsRegular() would catch this case and provide a clearer error message upfront.

Fix in Cursor Fix in Web


if _, err := os.Stat(testRunnerDir); os.IsNotExist(err) {
return handleErrorDuringBuild(build, "", fmt.Errorf("test runner dir (%s) does not exist", testRunnerDir))
}
Expand Down
Loading