Skip to content

[CDF-27790] 🪟 InField data migration creatable views#2942

Open
doctrino wants to merge 5 commits into
mainfrom
infield-creatable
Open

[CDF-27790] 🪟 InField data migration creatable views#2942
doctrino wants to merge 5 commits into
mainfrom
infield-creatable

Conversation

@doctrino
Copy link
Copy Markdown
Contributor

@doctrino doctrino commented Apr 24, 2026

Description

SHOULD NOT BE MERGED. This is a bug in the InField app and should not be fixed by the migration tooling.

Bump

  • Patch
  • Skip

Changelog

Added

  • [alpha] When running cdf migrate infield-data, Toolkit now sets visibility=PUBLIC and isArchived=false for all creatable views that has these properties set to None.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
42227 36168 86% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/_migrate/conversion.py 76% 🟢
TOTAL 76% 🟢

updated for commit: 6c067c4 by action🐍

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.65%. Comparing base (e70948d) to head (6c067c4).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...te_toolkit/_cdf_tk/commands/_migrate/conversion.py 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
- Coverage   85.69%   85.65%   -0.04%     
==========================================
  Files         461      461              
  Lines       42154    42227      +73     
==========================================
+ Hits        36122    36168      +46     
- Misses       6032     6059      +27     
Files with missing lines Coverage Δ
...te_toolkit/_cdf_tk/commands/_migrate/conversion.py 76.00% <25.00%> (-1.05%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino doctrino marked this pull request as ready for review April 24, 2026 06:49
@doctrino doctrino requested review from a team as code owners April 24, 2026 06:49
@doctrino doctrino force-pushed the infield-creatable branch from cfc0056 to ae2c6fb Compare April 24, 2026 06:49

is_archived = source_properties.get("isArchived", None)
if is_archived is None:
created_properties["isArchived"] = True
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
created_properties["isArchived"] = True
created_properties["isArchived"] = False

?

Comment thread cognite_toolkit/_cdf_tk/commands/_migrate/conversion.py Outdated
@doctrino doctrino added do-no-merge PR that should not be merged. labels Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-no-merge PR that should not be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants