Skip to content

remote body teleop from connect support#38011

Open
stefpi wants to merge 6 commits into
masterfrom
split/athenad-webrtcd
Open

remote body teleop from connect support#38011
stefpi wants to merge 6 commits into
masterfrom
split/athenad-webrtcd

Conversation

@stefpi
Copy link
Copy Markdown
Contributor

@stefpi stefpi commented May 12, 2026

add basic support for joystick livestream in connect

  • getNotCar and startJoystick dispatch in athena
  • better stream shutdown and cleanup (if another stream is opened, clean up and close previous one)
  • pass back better errors

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@stefpi stefpi mentioned this pull request May 12, 2026
@stefpi stefpi changed the title remote body teleop from connect remote body teleop from connect support May 12, 2026
@stefpi stefpi marked this pull request as ready for review May 12, 2026 01:56
Comment thread system/athena/athenad.py


@dispatcher.add_method
def getNotCar() -> bool:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a generic getMessage service already? maybe use that

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it's param, maybe generic getParam service then

Comment thread system/athena/athenad.py
except requests.ConnectTimeout:
raise Exception("webrtc took too long to respond. is it on?") from None
except requests.ConnectionError:
raise Exception("webrtc is not running. turn on comma body ignition.") from None
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hide exception chain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants