Use netavark create to fill out network config#610
Open
ashley-cui wants to merge 2 commits intocontainers:mainfrom
Open
Use netavark create to fill out network config#610ashley-cui wants to merge 2 commits intocontainers:mainfrom
ashley-cui wants to merge 2 commits intocontainers:mainfrom
Conversation
ashley-cui
force-pushed
the
netavarkcreate
branch
2 times, most recently
from
fa4eabd to
0a9721c
Compare
|
Packit jobs failed. @containers/packit-build please check. |
ashley-cui
force-pushed
the
netavarkcreate
branch
2 times, most recently
from
aaf14f5 to
c34e22b
Compare
ashley-cui
force-pushed
the
netavarkcreate
branch
3 times, most recently
from
23535d7 to
dac307f
Compare
Member
Author
|
Tests are passing here, but would love to do a vendor into podman before this merges, but that depends on new images which are currently failing. Hold tight.. |
Luap99
reviewed
Apr 20, 2026
ashley-cui
force-pushed
the
netavarkcreate
branch
2 times, most recently
from
c896fb5 to
e635760
Compare
Luap99
added
the
podman 6
6 tasks
ashley-cui
force-pushed
the
netavarkcreate
branch
from
e635760 to
188ff19
Compare
ashley-cui
added a commit
to ashley-cui/podman
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
netavarkcreate
branch
from
188ff19 to
cbe9f9a
Compare
ashley-cui
added a commit
to ashley-cui/podman
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
netavarkcreate
branch
from
cbe9f9a to
f5e09b0
Compare
Member
Author
|
Ready to review. Tests are passing in containers/podman#28570 except for one, which will be fixed in containers/netavark#1440. Please merge the netavark PR first to unblock podman vendoring. @containers/container-libs-maintainers PTAL |
ashley-cui
force-pushed
the
netavarkcreate
branch
from
f5e09b0 to
df86146
Compare
ashley-cui
added a commit
to ashley-cui/podman
that referenced
this pull request
Apr 24, 2026
For containers/container-libs#610 Signed-off-by: Ashley Cui <acui@redhat.com>
From containers/automation_images#443 Signed-off-by: Ashley Cui <acui@redhat.com>
Netavark now supports a new command, netavark create, which will take incomplete network configs, validate options, and return a completed config. Migrate c/common/libnetwork to use the netavark create command Requires a new netavark, but mostly non-breaking, other than now we enforce true/false for no default route - 0/1 is no longer supported Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
netavarkcreate
branch
from
df86146 to
0c8ff08
Compare
ashley-cui
added a commit
to ashley-cui/podman
that referenced
this pull request
Apr 25, 2026
For containers/container-libs#610 Signed-off-by: Ashley Cui <acui@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netavark now supports a new command, netavark create, which will take incomplete network configs, validate options, and return a completed config.
Migrate c/common/libnetwork to use the netavark create command
Requires a new netavark, but mostly non-breaking, other than now we enforce true/false for no default route - 0/1 is no longer supported