Skip to content

Use netavark create when creating networks #28570

Merged
mheon merged 2 commits intocontainers:mainfrom
ashley-cui:netavarkcreate
Apr 28, 2026
Merged

Use netavark create when creating networks #28570
mheon merged 2 commits intocontainers:mainfrom
ashley-cui:netavarkcreate

Conversation

@ashley-cui
Copy link
Copy Markdown
Member

@ashley-cui ashley-cui commented Apr 23, 2026

Throwing containers/container-libs#610 at CI

Netavark now supports a new command, netavark create, which will take incomplete network configs, validate options, and return a completed config.
Vendor c/common/libnetwork, which uses the netavark create command, and adjust the tests accordingly.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Breaking change: The `no_default_route` driver option for the `podman network create` command now requires `true|false`. `0|1` are no longer supported. 

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit bc7f1e5. @lsm5, @psss, @thrix please check.

@ashley-cui
Copy link
Copy Markdown
Member Author

ashley-cui commented Apr 23, 2026

@Luap99 Would it be okay if we required no_default_route=true and discontinued support for no_default_route=1 due to rust serialization? Or would you prefer to continue supporting it? Would be a 6.0 breaking change

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 7d048a3. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 4559183. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit f0d0fbc. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link
Copy Markdown

tmt tests failed for commit 86db852. @lsm5, @psss, @thrix please check.

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Apr 27, 2026

@Luap99 Would it be okay if we required no_default_route=true and discontinued support for no_default_route=1 due to rust serialization? Or would you prefer to continue supporting it? Would be a 6.0 breaking change

Generally speaking adding a custom parser on the rust side which can accepts 1 would not be to hard, but given the time I am fine to remove support for that. We can add it back if users complain

@ashley-cui ashley-cui closed this Apr 28, 2026
@ashley-cui ashley-cui reopened this Apr 28, 2026
@ashley-cui ashley-cui marked this pull request as ready for review April 28, 2026 14:34
@ashley-cui ashley-cui changed the title DNM: Test vendor of new netavark create function Use netavark create when creating networks Apr 28, 2026
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread go.mod Outdated
Comment on lines 67 to 69
go.podman.io/common v0.67.2-0.20260428141150-d5814603acf0
go.podman.io/image/v5 v5.39.3-0.20260427104901-081c2519fc6a
go.podman.io/storage v1.62.1-0.20260427104901-081c2519fc6a
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency it is best if we always vendor all modules to the same commit as they are all part of the same git repo, just in case you have to rebase/force push again. not blocking if tests go green

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to rebase on main to pick up #28597 for checkpoint failures

Comment thread test/system/500-networking.bats Outdated
Mostly for libnetwork changes in c/common

Signed-off-by: Ashley Cui <acui@redhat.com>
c/common uses the new netavark create command, so some of the error messages have slightly changed. Adjust the tests so they pass.

Signed-off-by: Ashley Cui <acui@redhat.com>
@packit-as-a-service
Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@Luap99 Luap99 added the 6.0 Breaking changes for Podman 6.0 label Apr 28, 2026
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @containers/podman-maintainers PTAL

@mheon
Copy link
Copy Markdown
Member

mheon commented Apr 28, 2026

Sure, LGTM

@mheon mheon enabled auto-merge April 28, 2026 17:26
@mheon mheon merged commit 70fc22c into containers:main Apr 28, 2026
86 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 Breaking changes for Podman 6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants