Use netavark create when creating networks #28570
Conversation
|
@Luap99 Would it be okay if we required |
bc7f1e5 to
7d048a3
Compare
7d048a3 to
4559183
Compare
4559183 to
f0d0fbc
Compare
f0d0fbc to
86db852
Compare
Generally speaking adding a custom parser on the rust side which can accepts 1 would not be to hard, but given the time I am fine to remove support for that. We can add it back if users complain |
86db852 to
bd86edc
Compare
7492ce8 to
c761bb4
Compare
| go.podman.io/common v0.67.2-0.20260428141150-d5814603acf0 | ||
| go.podman.io/image/v5 v5.39.3-0.20260427104901-081c2519fc6a | ||
| go.podman.io/storage v1.62.1-0.20260427104901-081c2519fc6a |
There was a problem hiding this comment.
for consistency it is best if we always vendor all modules to the same commit as they are all part of the same git repo, just in case you have to rebase/force push again. not blocking if tests go green
c761bb4 to
f3a1eb1
Compare
f3a1eb1 to
1ba0730
Compare
Mostly for libnetwork changes in c/common Signed-off-by: Ashley Cui <acui@redhat.com>
c/common uses the new netavark create command, so some of the error messages have slightly changed. Adjust the tests so they pass. Signed-off-by: Ashley Cui <acui@redhat.com>
1ba0730 to
bb02e49
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Luap99
left a comment
There was a problem hiding this comment.
LGTM, @containers/podman-maintainers PTAL
|
Sure, LGTM |
Throwing containers/container-libs#610 at CINetavark now supports a new command, netavark create, which will take incomplete network configs, validate options, and return a completed config.
Vendor c/common/libnetwork, which uses the netavark create command, and adjust the tests accordingly.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?