Skip to content

Added the simulation for the overarching simulation#27

Closed
ste93 wants to merge 42 commits intoconvince-project:mainfrom
BeniaminoSquitieri:fix/overarching-simulation
Closed

Added the simulation for the overarching simulation#27
ste93 wants to merge 42 commits intoconvince-project:mainfrom
BeniaminoSquitieri:fix/overarching-simulation

Conversation

@ste93
Copy link
Copy Markdown
Member

@ste93 ste93 commented Feb 17, 2026

Added the simulation with pyrobosim

ste93 and others added 8 commits February 16, 2026 17:21
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
…r, and modified btcpp_executor.cpp

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
@BeniaminoSquitieri BeniaminoSquitieri force-pushed the fix/overarching-simulation branch from 880cf5a to 818dfb9 Compare February 17, 2026 11:10
BeniaminoSquitieri and others added 14 commits February 17, 2026 15:38
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Stefano Bernagozzi <stefano.bernagozzi@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
…or changes

Increase RobotState publish rate in tutorial_sim run (state_pub_rate=5.0) to improve timing of dynamic Place resolution.

Make translate_component object resolution robust with current manipulated_object, default fallback, last seen value, and short wait window.

Keep forwarding semantics unchanged and update simulation/tutorial_sim READMEs with clear behavior and run guidance.

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
@BeniaminoSquitieri
Copy link
Copy Markdown

This PR is about all the changes that have been done in order to make all the BT working in simulation folder with pyrobotsim tools.

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
@ste93 ste93 marked this pull request as ready for review March 4, 2026 08:50
@ste93 ste93 requested review from artac72 and ct2034 March 4, 2026 08:51
@charlie1329
Copy link
Copy Markdown

Don't think this causes any issues on my end - for reference the PR for the refine-plan portion of the demo is here: #28

EnricoGhiorzi and others added 2 commits March 4, 2026 10:57
Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
@ste93 ste93 changed the title Fix/overarching simulation Added the simulation for the overarching simulation Mar 4, 2026
BeniaminoSquitieri and others added 3 commits March 16, 2026 17:56
…cution by fixing workspace/container startup configuration, adding a single-command orchestration to launch the full stack with selectable behavior tree and automatic shutdown on completion, resolving missing runtime dependencies, hardening node shutdown/reset handling to avoid teardown errors, reducing duplicate ROS logging noise, and correcting location-search behavior to use deterministic blackboard-driven progression with simulator-valid targets while preserving the original BT logic; additionally migrate the custom place skill definition to the updated model format.

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
- Add xml properties to main_locations
- Add xml properties to main_locations_failures_unhandled
- Add xml properties to main_locations_w_failures

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
@ste93 ste93 force-pushed the fix/overarching-simulation branch from ea503af to b6c55ac Compare March 18, 2026 13:41
…cution by fixing workspace/container startup configuration, adding a single-command orchestration to launch the full stack with selectable behavior tree and automatic shutdown on completion, resolving missing runtime dependencies, hardening node shutdown/reset handling to avoid teardown errors, reducing duplicate ROS logging noise, and correcting location-search behavior to use deterministic blackboard-driven progression with simulator-valid targets while preserving the original BT logic; additionally migrate the custom place skill definition to the updated model format.

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
@ste93 ste93 force-pushed the fix/overarching-simulation branch from b6c55ac to 4fbd8b9 Compare March 18, 2026 13:49
Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
…tieri/data-model into fix/overarching-simulation

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
…minoSquitieri/data-model into fix/overarching-simulation"

This reverts commit 728205c, reversing
changes made to 4fbd8b9.

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
@BeniaminoSquitieri BeniaminoSquitieri force-pushed the fix/overarching-simulation branch from 53acf0c to 715c3e2 Compare March 19, 2026 19:38
BeniaminoSquitieri and others added 4 commits March 19, 2026 20:43
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
…rticular the bt_plugin bt_ros2_action.ascxml has been added to fix this requirement

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
Strings `fridge` and `dining_table` were missing single quotes.

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
@EnricoGhiorzi
Copy link
Copy Markdown
Collaborator

@ste93 @BeniaminoSquitieri I pushed a small fix to the policies that apparently fixed the base version of the model (main.xml). The three other versions still fail building with AS2FM and I get the following error message:

Value of BT output port output_key must be a Blackboard variable reference.

Any idea what this might be about?

…properties.

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
@EnricoGhiorzi
Copy link
Copy Markdown
Collaborator

The last commit fixes the roaml issues I had and makes the models work as intended when verified with Scan.

- The location is called `'table'` in the model, not `'dining_table'`

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
- In the model, the snack is dropped on the table, not taken to the start location

Signed-off-by: Enrico Ghiorzi <enrico.ghiorzi@edu.unige.it>
… all BTs (without XML changes), aligned detect/pick fallback behavior and reduced noisy warnings, exposed the same option in the launch file, cleaned duplicated README instructions, and clarified that the selected object must already be spawned in the pickup location (with reference to the world config file)

Signed-off-by: Beniamino Squitieri <beniamino.squitieri@iit.it>
@EnricoGhiorzi
Copy link
Copy Markdown
Collaborator

Compared to my last test, this branch now breaks verification because of wrong quotes. Model will have lines such as: <assign location="tmp_location" expr="''''"/>.

@EnricoGhiorzi
Copy link
Copy Markdown
Collaborator

Also, trace shows robot drifting to -1000 which I think it was never supposed to do:

Time, Origin, Target, Event,               Values,                                                           parent: string, x: float64, y: float64
1000, world,  NONE,   topic_robot_loc_msg, "[ros_fields__parent: 1, ros_fields__x: -990, ros_fields__y: 0]", 1,              4,          2

@EnricoGhiorzi
Copy link
Copy Markdown
Collaborator

After a little investigation, I think the culprit is in the policy bt_tree.xml:

<NavigateToLocation name="navigate_to_obj" location="'fridge'" />

requesting navigation to 'fridge', while world only handles 'start' and 'table':

        <ros_action_handle_goal name="act_nav" target="handle_nav_request">
            <assign location="goal_id" expr="_action.goal_id" />
            <if cond="_goal.location_id == 'start'">
                <assign location="req_loc" expr="location_start" />
            <elseif cond="_goal.location_id == 'table'" />
                <assign location="req_loc" expr="location_table" />
            <else/>
                <assign location="req_loc.x" expr="-1000" /> <!-- Dummy x value, should never happen! -->
            </if>
            <ros_action_accept_goal name="act_nav" goal_id="goal_id" />
        </ros_action_handle_goal>

I don't know if this has to be fixed changing the BT or including the 'fridge' location in world. Notice that 'fridge' is already included in world_multiple_locations.

@ct2034
Copy link
Copy Markdown
Member

ct2034 commented Apr 8, 2026

replicated in convince-project/overview#37

@ct2034 ct2034 closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants