This repository was archived by the owner on Sep 22, 2020. It is now read-only.
Update unit examples to template units and new X-Fleet syntax#5
Open
emmanuel wants to merge 2 commits intocoreos:masterfrom
Open
Update unit examples to template units and new X-Fleet syntax#5emmanuel wants to merge 2 commits intocoreos:masterfrom
emmanuel wants to merge 2 commits intocoreos:masterfrom
Conversation
Also convert to new X-Fleet syntax.
Also convert to new X-Fleet syntax.
Author
|
Er, sorta. He mentioned it in passing, but the content itself is all my fault. :) |
Member
|
We should avoid changing the apache units since the new units won't match the existing guide (linked in readme) |
Author
|
Maybe I should just update the guide to use the new syntax as well? If so, is the guide in a github repo? |
Member
|
If you're willing, that would be sweet. The guide is here: https://github.com/coreos/docs/blob/master/launching-containers/launching/launching-containers-fleet/index.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @robszumski on IRC.