feat: force ready status for desired objects#153
Open
eegseth wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
feat: force ready status for desired objects#153eegseth wants to merge 2 commits intocrossplane-contrib:mainfrom
eegseth wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Endre Egseth <endre.egseth@lanekassen.no>
eegseth
requested review from
negz,
sergenyalcin and
turkenf
as code owners
|
Any update on this? It would be a nice feature. |
Contributor
|
This is probably superseded by #160. Also there are ways to specify individual resource readiness in the composing functions - like the annotation used by function-go-templating |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds possibility to force readiness for desired objects from the composition. Useful for objects that does not have a status field etc.
This PR just picks up the ball from PR #33 (thanks to @tomaszkiewicz).
Fixes #29
I have:
[x] Read and followed Crossplane's [contribution process].
[ ] Added or updated unit tests for my change.