fix: set Ready for resources that miss status.conditions - second attempt#33
Draft
tomaszkiewicz wants to merge 3 commits intocrossplane-contrib:mainfrom
Draft
fix: set Ready for resources that miss status.conditions - second attempt#33tomaszkiewicz wants to merge 3 commits intocrossplane-contrib:mainfrom
tomaszkiewicz wants to merge 3 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Lukasz Tomaszkiewicz <luktom@luktom.net>
… the function should force readiness
briferz
approved these changes
Nov 12, 2024
Contributor
|
#160 resolved this issue for native kubernetes resources, and there are methods of indicating resource readiness in the composing functions, like the annotation used by function-go-templating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #29 @reedjosh
This is a second attempt, that uses function input to specify GVKs that should have forced readiness.
Sample usage:
I have: