fix: drain HTTP body, paginate Qdrant scroll, deduplicate extractUniqueDirs#2
Draft
fix: drain HTTP body, paginate Qdrant scroll, deduplicate extractUniqueDirs#2
Conversation
…xtractUniqueDirs Co-authored-by: danilin-em <46928452+danilin-em@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Conduct code review for project analysis
fix: drain HTTP body, paginate Qdrant scroll, deduplicate extractUniqueDirs
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review of the VedCode project surfaced three issues.
HTTP connection leak in
EnsureCollectionResponse body not drained before close, preventing keep-alive connection reuse.
Hardcoded scroll limit of 1000
GetAllFilePoints/GetAllDirPointsused a single scroll request withlimit: 1000. Projects exceeding that silently drop records — stale files aren't cleaned up and unchanged files get re-indexed.Extracted
scrollAll()with cursor-based pagination via Qdrant'snext_page_offset. AddedTestGetAllFilePoints_Paginationcovering multi-page retrieval.Redundant
extractUniqueDirscallindexer.Run()computedextractUniqueDirs(walkResult.Files)twice with the same input. Reused the existingcurrentDirsvariable.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.