[GUI] Latitude is not the best term for linear region of the curve#20911
Open
victoryforce wants to merge 1 commit intodarktable-org:masterfrom
Open
[GUI] Latitude is not the best term for linear region of the curve#20911victoryforce wants to merge 1 commit intodarktable-org:masterfrom
victoryforce wants to merge 1 commit intodarktable-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I should have checked what effect the changes in #20880 would have. The change seemed so trivial that I didn't. But the problem is that changing the parameter name in
dt_bauhaus_slider_from_paramsbreaks the introspective connection of this widget with the corresponding parameter. :-(So, first of all, this PR fixes the introduced breakage. But the problem remains that the word "latitude" has primarily a geographical meaning. Accordingly, in translations there can be terms that have only this meaning. In fact, this is the case at least in the Czech translation, where the translation "
zeměpisná šírka" literally means "geographic latitude". So the current Czech translation of the slider in Filmic RGB looks extremely surprising.I started to research whether "latitude" is really a common term for the linear part of a curve. I didn't find anything like that, it seems more like it's a name invented by the module author. The only thing that comes to mind when the word latitude is used in a photographic context is "exposure latitude"which is a completely different concept and is another reason why "latitude" in the context of a curve is a poor name choice.
This PR changes the name of the slider from "latitude" to "linear region" which is a common term, short enough for a label in the GUI and completely self-explanatory without having to guess the meaning.