Skip to content

[GUI] Latitude is not the best term for linear region of the curve #20911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victoryforce wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[GUI] Latitude is not the best term for linear region of the curve #20911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iop/filmic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ void gui_init(dt_iop_module_t *self)
// latitude slider
g->latitude_stops = dt_bauhaus_slider_new_with_range(self, 0.01, 16.0, 0, p->latitude_stops, 3);
dt_bauhaus_slider_set_soft_range(g->latitude_stops, 2, 8.0);
dt_bauhaus_widget_set_label(g->latitude_stops, NULL, NC_("curve-linear-part-width", "latitude"));
dt_bauhaus_widget_set_label(g->latitude_stops, NULL, N_("linear region"));
dt_bauhaus_slider_set_format(g->latitude_stops, _(" EV"));
gtk_widget_set_tooltip_text(g->latitude_stops,
_("width of the linear domain in the middle of the curve.\n"
Expand Down
4 changes: 2 additions & 2 deletions src/iop/filmicrgb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ typedef struct dt_iop_filmicrgb_params_t
float black_point_target; // $MIN: 0.000 $MAX: 20.000 $DEFAULT: 0.01517634 $DESCRIPTION: "target black luminance"
float white_point_target; // $MIN: 0 $MAX: 1600 $DEFAULT: 100 $DESCRIPTION: "target white luminance"
float output_power; // $MIN: 1 $MAX: 10 $DEFAULT: 4.0 $DESCRIPTION: "hardness"
float latitude; // $MIN: 0.01 $MAX: 99 $DEFAULT: 0.01
float latitude; // $MIN: 0.01 $MAX: 99 $DEFAULT: 0.01 $DESCRIPTION: "linear region"
float contrast; // $MIN: 0 $MAX: 5 $DEFAULT: 1.0
float saturation; // $MIN: -200 $MAX: 200 $DEFAULT: 0 $DESCRIPTION: "extreme luminance saturation"
float balance; // $MIN: -50 $MAX: 50 $DEFAULT: 0.0 $DESCRIPTION: "shadows ↔ highlights balance"
Expand Down Expand Up @@ -4510,7 +4510,7 @@ void gui_init(dt_iop_module_t *self)
"increase to make highlights brighter and less compressed.\n"
"decrease to mute highlights."));

g->latitude = dt_bauhaus_slider_from_params(self, NC_("curve-linear-part-width", "latitude"));
g->latitude = dt_bauhaus_slider_from_params(self, "latitude");
dt_bauhaus_slider_set_soft_range(g->latitude, 0.1, 90.0);
dt_bauhaus_slider_set_format(g->latitude, "%");
gtk_widget_set_tooltip_text(g->latitude,
Expand Down