Fix purge_nonexistent_images.bat to correctly handle images which have cyrillic (or other alphabets) in the path#20916
Open
mishavoloshchuk wants to merge 1 commit intodarktable-org:masterfrom
Conversation
…ve deletion logic
TurboGit
approved these changes
May 3, 2026
Member
TurboGit
left a comment
There was a problem hiding this comment.
Looks ok by me but I'd like the review of a Windows expert;
@wpferguson : Can you review please? TIA
Member
|
@victoryforce are you able to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a fix for the purge_nonexistent_images.bat removes existing files / #20915 issue I recently added. I used Claude, because I'm not very proficient in .bat scripts. I've checked it and works completely fine and now it only removes the images that are really missing.
Here is some description from Claude itself: