Skip to content

Fix purge_nonexistent_images.bat to correctly handle images which have cyrillic (or other alphabets) in the path #20916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mishavoloshchuk wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −5
Open

Fix purge_nonexistent_images.bat to correctly handle images which have cyrillic (or other alphabets) in the path #20916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions tools/purge_nonexistent_images.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
::

@echo off
chcp 65001 >nul

where.exe /q sqlite3
if %ERRORLEVEL% EQU 1 (
echo Error: sqlite3.exe is not installed or is not in PATH
Expand Down Expand Up @@ -72,9 +74,15 @@ if %dryrun% EQU 0 (

set ids=

:: Write sqlite3 output to a temp UTF-8 file to preserve Cyrillic characters.
:: Direct 'for /f ... in (\'sqlite3 ...\')' re-encodes output through the
:: legacy OEM code page, corrupting non-ASCII paths even with chcp 65001.
set TMPFILE=%TEMP%\dt_purge_tmp_%RANDOM%.txt
sqlite3.exe -utf8 %DBFILE% %QUERY% > "%TMPFILE%"

setlocal EnableDelayedExpansion
for /f "tokens=1* delims=|" %%a in ('sqlite3.exe %DBFILE% %QUERY%') do (
if not exist %%b (
for /f "usebackq tokens=1* delims=|" %%a in ("%TMPFILE%") do (
if not exist "%%b" (
echo. %%b with ID %%a
if .!ids!==. (
set ids=%%a
Expand All @@ -84,16 +92,18 @@ for /f "tokens=1* delims=|" %%a in ('sqlite3.exe %DBFILE% %QUERY%') do (
)
)

del "%TMPFILE%" >nul 2>&1

if %dryrun% EQU 0 (
echo This is NOT dry run
for %%a in (images,meta_data) do (
echo Removing from %%a...
sqlite3 %DBFILE% "DELETE FROM %%a WHERE id IN (%ids%)"
sqlite3 %DBFILE% "DELETE FROM %%a WHERE id IN (!ids!)"
)

for %%a in (color_labels,history,masks_history,selected_images,tagged_images,history_hash,module_order) do (
echo Removing from %%a...
sqlite3 %DBFILE% "DELETE FROM %%a WHERE imgid in (%ids%)"
sqlite3 %DBFILE% "DELETE FROM %%a WHERE imgid in (!ids!)"
)

rem delete now-empty film rolls
Expand All @@ -109,6 +119,7 @@ if %dryrun% EQU 0 (
echo %commandline% --purge
)

endlocal
exit 0

:HELP
Expand All @@ -121,4 +132,4 @@ echo: (default: '%configdir%')
echo: -l^|--library ^<path^> path to the library database file
echo: (default: '%DBFILE%')
echo: -p^|--purge actually purge the nonexistent images instead of just finding them
exit 0
exit 0