[AI] Fix segfault on quit in neural restore gui_cleanup#20931
Open
andriiryzhkov wants to merge 1 commit intodarktable-org:masterfrom
Open
[AI] Fix segfault on quit in neural restore gui_cleanup#20931andriiryzhkov wants to merge 1 commit intodarktable-org:masterfrom
andriiryzhkov wants to merge 1 commit intodarktable-org:masterfrom
Conversation
1 task
TurboGit
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20928
On quit,
gui_cleanupflushed all pending events in the GLib main loop. One of them was a stale callback from another plugin already mid-teardown, and dispatching it crashed.Fix
gui_cleanupalready ran.gui_cleanupso none can fire mid-cleanup.Tested on macOS and Linux.