Skip to content

feat(ui): DashPay model views in the storage explorer#832

Merged
QuantumExplorer merged 1 commit into
swift-sdk-integrationfrom
feat/storage-explorer-dashpay
Jul 16, 2026
Merged

feat(ui): DashPay model views in the storage explorer#832
QuantumExplorer merged 1 commit into
swift-sdk-integrationfrom
feat/storage-explorer-dashpay

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

The storage explorer covered 19 of the SDK's 34 SwiftData models — and none of the DashPay family. This ports the example app's views for the missing DashPay models:

Model Explorer row
PersistentDPNSName DPNS Names
PersistentDashpayProfile DashPay Profiles
PersistentDashpayContactProfile Contact Profiles
PersistentDashpayContactRequest Contact Requests (grouped Outgoing / Incoming)
PersistentDashpayPayment DashPay Payments
PersistentInvitation Sent Invitations
PersistentDashpayIgnoredSender Ignored Senders

Each gets a list view + full field-dump detail view (copyable rows), matching the existing explorer conventions. Adaptations from the example app: per-network filtering dropped (dashwallet's ModelContainer is per-network already), AppDate → the local dateString helper, and the contact-request detail additionally surfaces the owner-private alias/note meta that backs the contacts list titles and payment-row aliases.

Second commit — full parity

The remaining example-app views are ported too: Pending Inputs, Asset Locks (linked-identity resolution; recipient platform address encoded via the app's shared Bech32m instead of the example's private encoder; statusLabel extension added since the SDK doesn't ship it), Masternodes, Shielded Notes (All/Unspent/Spent filter), Shielded Sent Notes, Shielded Activity, Shielded Sync State, Shielded Viewing Keys. Every SDK SwiftData model (34/34) is now browsable.

Still unported (done in the second commit) (follow-up material if wanted): asset locks, pending inputs, masternodes, and the five shielded views.

Test plan

  • Clean dashpay simulator build (arm64); installed on QA-iPhone16
  • Tools → Storage Explorer shows the seven new rows with live counts; contact request / payment / profile drill-downs render the QA wallet's real rows

🤖 Generated with Claude Code

The explorer covered 19 of the SDK's 34 SwiftData models and skipped
the entire DashPay family. Port the example app's views for DPNS names,
DashPay profiles, contact profiles, contact requests (grouped
outgoing/incoming), DashPay payments, sent invitations, and ignored
senders — list + detail each, plus the explorer rows. The example app's
per-network filtering is dropped (dashwallet's ModelContainer is
per-network already), and the contact-request detail additionally
surfaces the owner-private alias/note meta the contacts UI writes.

Still unported from the example app's explorer (follow-up material):
asset locks, pending inputs, masternodes, and the five shielded views.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03482bf2-48ef-463f-82a2-4b98f23321b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/storage-explorer-dashpay

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer merged commit b671945 into swift-sdk-integration Jul 16, 2026
2 checks passed
QuantumExplorer added a commit that referenced this pull request Jul 16, 2026
The DashPay / asset-lock / masternode / shielded rows added in #832
read their badge from the counts dictionary, but loadCounts() was never
taught about their models — every new row showed 0 while its drill-in
@query list rendered the real records (QA: "Contact Requests 0" outside,
4 rows inside). Count all fifteen ported models.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant