Skip to content

ci: disable carryforward flags to flush stale data#543

Merged
xdustinface merged 1 commit intov0.42-devfrom
ci/disable-carryforward
Mar 15, 2026
Merged

ci: disable carryforward flags to flush stale data#543
xdustinface merged 1 commit intov0.42-devfrom
ci/disable-carryforward

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Mar 15, 2026

Stale carryforward flags from a previous per-crate flag config are inflating the session count and causing premature codecov status checks. Disabling carryforward temporarily so a clean CI run establishes fresh baseline data for the current flags.

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration to adjust carryforward settings.

Stale `carryforward` flags from a previous per-crate flag config
are inflating the session count and causing premature codecov
status checks. Disabling carryforward temporarily so a clean
CI run establishes fresh baseline data for the current flags.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffa9c5df-c90e-4224-921a-edd031a031e0

📥 Commits

Reviewing files that changed from the base of the PR and between 6749114 and b01ce20.

📒 Files selected for processing (1)
  • .codecov.yml

📝 Walkthrough

Walkthrough

A configuration change to .codecov.yml modifies the flag_management.default_rules setting, disabling the carryforward option. This represents a single-line configuration adjustment with no behavioral logic changes.

Changes

Cohort / File(s) Summary
Codecov Configuration
.codecov.yml
Modified flag_management.default_rules to set carryforward from true to false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tiny flag doth turn from green to nay,
Configuration dance in subtle way,
Carryforward rests, no more shall roam,
The codecov config finds its home!
wiggles nose

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: disable carryforward flags to flush stale data' directly matches the main change: disabling carryforward in .codecov.yml to address stale data issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/disable-carryforward
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.96%. Comparing base (6749114) to head (b01ce20).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #543      +/-   ##
=============================================
- Coverage      66.87%   65.96%   -0.92%     
=============================================
  Files            313      311       -2     
  Lines          64753    64586     -167     
=============================================
- Hits           43305    42602     -703     
- Misses         21448    21984     +536     
Flag Coverage Δ
core 75.02% <ø> (ø)
dash-network ?
dash-network-ffi ?
dash-spv ?
dash-spv-ffi ?
dashcore ?
dashcore-private ?
dashcore-rpc ?
dashcore-rpc-json ?
dashcore_hashes ?
ffi 37.14% <ø> (+0.01%) ⬆️
key-wallet ?
key-wallet-ffi ?
key-wallet-manager ?
rpc 19.92% <ø> (ø)
spv 81.04% <ø> (-0.06%) ⬇️
wallet 65.67% <ø> (ø)
see 17 files with indirect coverage changes

@xdustinface xdustinface merged commit e6e6964 into v0.42-dev Mar 15, 2026
52 checks passed
@xdustinface xdustinface deleted the ci/disable-carryforward branch March 15, 2026 10:52
xdustinface added a commit that referenced this pull request Mar 15, 2026
xdustinface added a commit that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants