Skip to content

ci: re-enable carryforward flags (#543)#544

Merged
xdustinface merged 1 commit intov0.42-devfrom
ci/enable-carryforward
Mar 15, 2026
Merged

ci: re-enable carryforward flags (#543)#544
xdustinface merged 1 commit intov0.42-devfrom
ci/enable-carryforward

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Mar 15, 2026

This reverts commit e6e6964.

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration settings to enhance flag carryforward behavior tracking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df92a870-4b8d-44ec-94b3-2cf290166e16

📥 Commits

Reviewing files that changed from the base of the PR and between f2d495b and d2f43b9.

📒 Files selected for processing (1)
  • .codecov.yml

📝 Walkthrough

Walkthrough

The codecov configuration's default carryforward behavior for flag management was toggled from disabled to enabled, allowing flags to persist across builds by default under the global flag_management.default_rules setting.

Changes

Cohort / File(s) Summary
Codecov Configuration
.codecov.yml
Modified flag_management.default_rules.carryforward from false to true, enabling default carryforward behavior for flags.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A humble flag now carries on,
Through builds and tests, the setting's gone,
From false to true, a simple switch,
Our codecov config gets its fix! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: re-enabling carryforward flags in the codecov configuration by changing the setting from false to true.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/enable-carryforward
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface merged commit 4b02de1 into v0.42-dev Mar 15, 2026
50 checks passed
@xdustinface xdustinface deleted the ci/enable-carryforward branch March 15, 2026 15:32
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.96%. Comparing base (f2d495b) to head (d2f43b9).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@            Coverage Diff             @@
##           v0.42-dev     #544   +/-   ##
==========================================
  Coverage      65.95%   65.96%           
==========================================
  Files            311      311           
  Lines          64586    64586           
==========================================
+ Hits           42600    42601    +1     
+ Misses         21986    21985    -1     
Flag Coverage Δ
core 75.02% <ø> (ø)
ffi 37.14% <ø> (ø)
rpc 19.92% <ø> (ø)
spv 81.03% <ø> (+<0.01%) ⬆️
wallet 65.67% <ø> (ø)
see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant