refactor: replace private[this] with private#1002
Open
He-Pin wants to merge 1 commit into
Open
Conversation
Motivation: `private[this]` restricts access to the current instance only, but in singleton objects there is only one instance, making it semantically identical to `private`. In the final class `StringBuilderWriter`, the `builder` field has no cross-instance access. Using `private` uniformly simplifies the access modifier vocabulary without changing behavior. Modification: - Renderer.scala: `private[this] val builder` → `private val builder` - SetModule.scala: 8 `private[this] final val` constants and 2 `@inline private[this] def` methods → `private` / `@inline private` Result: Cleaner, more idiomatic Scala with no semantic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
private[this]restricts access to the current instance only, but insingleton
objects there is only one instance, making it semanticallyidentical to
private. In thefinal class StringBuilderWriter, thebuilderfield has no cross-instance access. Usingprivateuniformlysimplifies the access modifier vocabulary without changing behavior.
Modification
Renderer.scala:private[this] val builder->private val builder(no cross-instance
.builderaccess exists).SetModule.scala: 8private[this] final valconstants and 2@inline private[this] defmethods ->private/@inline private.Result
Cleaner, more idiomatic Scala with no semantic change. Compiles
cleanly on Scala 2.12/2.13/3.3 and all tests pass.
References
None — pure style refactor.