Skip to content

refactor: replace private[this] with private #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −12
Open

refactor: replace private[this] with private #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sjsonnet/src/sjsonnet/Renderer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import java.io.{StringWriter, Writer}
import upickle.core.{ArrVisitor, ObjVisitor}

final class StringBuilderWriter(initialCapacity: Int = 16) extends Writer {
private[this] val builder = new java.lang.StringBuilder(initialCapacity)
private val builder = new java.lang.StringBuilder(initialCapacity)

/**
* Exposes the underlying [[java.lang.StringBuilder]] for callers that need direct
Expand Down
22 changes: 11 additions & 11 deletions sjsonnet/src/sjsonnet/stdlib/SetModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ object SetModule extends AbstractFunctionModule {
def name = "set"

private val DefaultKeyF = Val.Null(dummyPos)
private[this] final val SortKindOther = 0
private[this] final val SortKindString = 1
private[this] final val SortKindNumber = 2
private[this] final val SortKindArray = 3
private[this] final val SortKindBoolean = 4
private[this] final val SortKindObject = 5
private[this] final val SortKindNull = 6
private[this] final val SortKindFunction = 7

@inline private[this] def sortKind(v: Val): Int = v match {
private final val SortKindOther = 0
private final val SortKindString = 1
private final val SortKindNumber = 2
private final val SortKindArray = 3
private final val SortKindBoolean = 4
private final val SortKindObject = 5
private final val SortKindNull = 6
private final val SortKindFunction = 7

@inline private def sortKind(v: Val): Int = v match {
case _: Val.Str => SortKindString
case _: Val.Num => SortKindNumber
case _: Val.Arr => SortKindArray
Expand All @@ -44,7 +44,7 @@ object SetModule extends AbstractFunctionModule {
case _ => SortKindOther
}

@inline private[this] def allSameSortKind(values: Array[Val], kind: Int): Boolean = {
@inline private def allSameSortKind(values: Array[Val], kind: Int): Boolean = {
var i = 1
while (i < values.length) {
if (sortKind(values(i)) != kind) return false
Expand Down
Loading