Upgrade to DataFusion 54#55
Merged
Merged
Conversation
geoffreyclaude
commented
May 27, 2026
| /// This relies on the internal optimization context being active in the current thread. | ||
| pub(crate) fn is_instrumented(plan: &dyn ExecutionPlan) -> bool { | ||
| plan.as_any().is::<InstrumentedExec>() | ||
| plan.is::<InstrumentedExec>() |
Collaborator
Author
There was a problem hiding this comment.
Updated after apache/datafusion#22565 merged into DataFusion branch-54. This PR now uses ExecutionPlan::downcast_delegate so InstrumentedExec remains transparent for public plan downcasts, and is_instrumented uses a direct Any check for the internal double-wrapping guard in this crate.
geoffreyclaude
force-pushed
the
branch-54
branch
3 times, most recently
from
af4007f to
f84a60f
Compare
gabotechs
approved these changes
Jun 8, 2026
geoffreyclaude
force-pushed
the
branch-54
branch
3 times, most recently
from
9e63f4b to
610c902
Compare
geoffreyclaude
changed the base branch from
main
to
codex/stabilize-async-span-tests
geoffreyclaude
changed the base branch from
codex/stabilize-async-span-tests
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades
datafusion-tracingto DataFusion 54.0.0.Changes included here:
54.0.0.datafusion = "54.0.0"crate from crates.io.ExecutionPlan::downcast_delegatehook soInstrumentedExecremains transparent for public plan downcasts whiledatafusion-tracingcan still detect existing wrappers internally.Status
DataFusion 54.0.0 has been released, so this PR no longer depends on an Apache DataFusion
branch-54git revision.The transparent-wrapper blocker from apache/datafusion#22557 is resolved by apache/datafusion#22565, which is included in the released crate.
Validation
cargo fmt --all --checkgit diff --check codex/stabilize-async-span-tests...HEADcargo test --workspace --quiet