Skip to content

Stabilize async span-capture tests#58

Merged
geoffreyclaude merged 1 commit into
mainfrom
codex/stabilize-async-span-tests
Jun 8, 2026
Merged

Stabilize async span-capture tests#58
geoffreyclaude merged 1 commit into
mainfrom
codex/stabilize-async-span-tests

Conversation

@geoffreyclaude

@geoffreyclaude geoffreyclaude commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This pulls stabilization-only changes out of the DataFusion 54 upgrade branch so #55 can stay focused on the dependency/API update.

What Changed

  • Propagate the span-capture subscriber across async poll boundaries in unit tests instead of relying on thread-local scoped defaults.
  • Apply the same subscriber propagation to the stale optimizer phase-span regression test.
  • Normalize duplicate recursive execution close events in the all-options recursive integration snapshot while keeping preview assertions based on the uncollapsed trace.

Scope

This does not change DataFusion dependencies or production instrumentation behavior.

Validation

  • cargo fmt --all --check
  • git diff --check
  • INSTA_UPDATE=always cargo test -p datafusion-tracing-tests --test integration_tests test_recursive_all_options -- --exact
  • cargo test -p datafusion-tracing --lib --quiet
  • cargo test --workspace --quiet

@geoffreyclaude geoffreyclaude merged commit c32e520 into main Jun 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants