fix(hybrid-ep): replace deprecated pynvml dependency with nvidia-ml-py#601
Open
ooooo-create wants to merge 1 commit intodeepseek-ai:hybrid-epfrom
Open
fix(hybrid-ep): replace deprecated pynvml dependency with nvidia-ml-py#601ooooo-create wants to merge 1 commit intodeepseek-ai:hybrid-epfrom
ooooo-create wants to merge 1 commit intodeepseek-ai:hybrid-epfrom
Conversation
Signed-off-by: ooooo <3164076421@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s packaging dependency to avoid downstream FutureWarnings triggered by the deprecated pynvml package while preserving the existing import pynvml runtime behavior via NVIDIA’s maintained bindings.
Changes:
- Replaced
pynvmlwithnvidia-ml-py>=12.0.0insetup.pyinstall_requires.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated
pynvmlpackage withnvidia-ml-py>=12.0.0insetup.py.pynvmlis now deprecated and can trigger aFutureWarningin downstream environments whentorch.cudais imported. Sincenvidia-ml-pyprovides the official NVIDIA-maintained NVML bindings and preserves thepynvmlmodule import path, switching the dependency resolves the warning without changing runtime behavior.The
>=12.0.0lower bound matches the compatibility floor already implied by the deprecatedpynvmlpackage itself.