-
Notifications
You must be signed in to change notification settings - Fork 0
feat: adopt world-at-ruin declaratively (repository, labels, team grants) #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eca798a
feat: adopt world-at-ruin declaratively (repository, labels, team gra…
devantler e511647
fix: keep admins grant default-off (unreferenced), per policy test
devantler 9fe9c31
test: extend default-off Admins policy tripwire to world-at-ruin
devantler ffbcedf
fix: stage labels Observe-only, add actions-permissions binding, corr…
devantler 66ecb9d
fix: stage the Repository adoption Observe-only, per the two-stage flow
devantler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Issue labels for devantler-tech/world-at-ruin. The canonical org taxonomy (22 labels) | ||
| # is appended to every IssueLabels by the shared patch in kustomization.yaml; this | ||
| # file adds only world-at-ruin's repo-specific extras (none yet). See ../README.md. | ||
| # | ||
| # Observe-only for now: this CR binds to a pre-existing repo whose live labels it | ||
| # has not yet observed — with Update active from the first deploy it could replace | ||
| # the live label set before adoption. Promote to the full policy set (all except | ||
| # Delete) once Synced/Ready shows the observed state matches the declared one. | ||
| apiVersion: repo.github.m.upbound.io/v1alpha1 | ||
| kind: IssueLabels | ||
| metadata: | ||
| name: world-at-ruin | ||
| annotations: | ||
| crossplane.io/external-name: world-at-ruin | ||
| spec: | ||
| managementPolicies: | ||
| - Observe | ||
| forProvider: | ||
| repository: world-at-ruin | ||
| # No repo-specific extras; the shared patch supplies the full canonical set. | ||
| label: [] | ||
| providerConfigRef: | ||
| kind: ProviderConfig | ||
| name: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| apiVersion: repo.github.m.upbound.io/v1alpha1 | ||
| kind: Repository | ||
| metadata: | ||
| name: world-at-ruin | ||
| annotations: | ||
| crossplane.io/external-name: world-at-ruin | ||
| spec: | ||
| # Observe-only for now: adopts the imperatively bootstrapped repo (org | ||
| # custom-property requirement — see the repo-creation bootstrap pattern) | ||
| # without writing to it; the shared merge-policy patch would otherwise apply | ||
| # before the observed state is reviewed. Promote to the full set except | ||
| # Delete (and pin visibility/description as authoritative) once Synced/Ready | ||
| # shows the observed state, per the two-stage flow in kustomization.yaml. | ||
| managementPolicies: | ||
| - Observe | ||
| forProvider: | ||
| name: world-at-ruin | ||
| providerConfigRef: | ||
| kind: ProviderConfig | ||
| name: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Actions permissions for devantler-tech/world-at-ruin — binds the org-wide | ||
| # shaPinningRequired policy (asserted once in kustomization.yaml) to this repo. | ||
| # Observe+LateInitialize adopts the repo's live enabled/allowedActions so turning | ||
| # on SHA-pinning never disturbs them. See ../README.md. | ||
| apiVersion: actions.github.m.upbound.io/v1alpha1 | ||
| kind: RepositoryPermissions | ||
| metadata: | ||
| name: world-at-ruin | ||
| annotations: | ||
| crossplane.io/external-name: world-at-ruin | ||
| spec: | ||
| managementPolicies: | ||
| - Observe | ||
| - Create | ||
| - Update | ||
| - LateInitialize | ||
| forProvider: | ||
| repository: world-at-ruin | ||
| providerConfigRef: | ||
| kind: ProviderConfig | ||
| name: default |
17 changes: 17 additions & 0 deletions
17
deploy/team-repositories/grant-admins-on-world-at-ruin.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Default-off Admins-team repository grant. No external-name is set because the | ||
| # separate team and its admin grant do not exist yet; activation creates them | ||
| # without claiming Delete management. | ||
| apiVersion: team.github.m.upbound.io/v1alpha1 | ||
| kind: TeamRepository | ||
| metadata: | ||
| name: admins-world-at-ruin | ||
| spec: | ||
| managementPolicies: ["Observe", "Create", "Update", "LateInitialize"] | ||
| forProvider: | ||
| teamIdRef: | ||
| name: admins | ||
| repository: world-at-ruin | ||
| permission: admin | ||
| providerConfigRef: | ||
| kind: ProviderConfig | ||
| name: default |
16 changes: 16 additions & 0 deletions
16
deploy/team-repositories/grant-maintainers-on-world-at-ruin.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Team → repository access. No external-name: this grant does not exist yet, so it is | ||
| # Created (full management except Delete) rather than adopted. | ||
| apiVersion: team.github.m.upbound.io/v1alpha1 | ||
| kind: TeamRepository | ||
| metadata: | ||
| name: maintainers-world-at-ruin | ||
| spec: | ||
| managementPolicies: ["Observe", "Create", "Update", "LateInitialize"] | ||
| forProvider: | ||
| teamIdRef: | ||
| name: maintainers | ||
| repository: world-at-ruin | ||
| permission: maintain | ||
| providerConfigRef: | ||
| kind: ProviderConfig | ||
| name: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.