-
Notifications
You must be signed in to change notification settings - Fork 5
Bump go and deps #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go and deps #166
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Welp, broke crossbuilds, one sec |
Resulting binary not tested. Cross-building with mingw_w64_pthreads broken in nixpkgs 24.11 for some reason.
Cross-building on 24.11 seems to be broken
|
Fixed cross-building for Linux and Windows, but cannot get it to work for macOS (neither for ARM, nor for X86) with 24.11. So instead creating a hacky fix by using nixpkgs 25.05 for crossBuilds: 635976f Alternatively we could use |
Could we use 25.05 everywhere? |
I don't think it's a good idea, since PlayOS is at 24.11 and so our production build would be different from dev builds. Unless we change the release process to ship an actual binary. |
knuton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just waiting for macOS build confirmation before merge.
|
|
|
rerunning |
|
Flakiness on macOS traced to before this PR, will tackle independently. |
Bumping go to 1.23 to be able to update x/net and bumping logrus. This should resolve the remaining Dependabot issues, the others I reviewed and dismissed manually.