Fix #11047: Sufficiently big BigUint multiplications fail during CTFE#11048
Open
just-harry wants to merge 1 commit into
Open
Fix #11047: Sufficiently big BigUint multiplications fail during CTFE#11048just-harry wants to merge 1 commit into
just-harry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Feature request or issue tracking
Closes #11047.
Pre-review checklist
When both operands of a
std.internal.math.biguintcore.BigUintmultiplication exceed a certain threshold (the threshold appears to be1 << 32) during CTFE, the multiplication will fail asstd.internal.math.biguintcore.mulInternalattempts to usecore.cpuid.dataCaches, viastd.internal.math.biguintcore.getCacheLimit, to optimise algorithm selection.The proposed fix is simple: use an arbitrary value for
getCacheLimit, during CTFE, in lieu ofcore.cpuid.dataCaches.getCacheLimitis used in one place, and solely to optimise algorithm selection; no functional change is introduced by this PR.