Skip to content

Fix #11047: Sufficiently big BigUint multiplications fail during CTFE #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
just-harry wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −2
Open

Fix #11047: Sufficiently big BigUint multiplications fail during CTFE #11048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions std/internal/math/biguintcore.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,16 @@ else alias multibyteSquare = std.internal.math.biguintnoasm.multibyteSquare;
// Half the size of the data cache.
@nogc nothrow pure @safe size_t getCacheLimit()
{
import core.cpuid : dataCaches;
return dataCaches[0].size * 1024 / 2;
if (__ctfe)
{
// Chosen arbitrarily.
return 8192;
}
else
{
import core.cpuid : dataCaches;
return dataCaches[0].size * 1024 / 2;
}
}
enum size_t FASTDIVLIMIT = 100; // crossover to recursive division

Expand Down Expand Up @@ -1267,6 +1275,12 @@ public:
assert(BigUint.mulInt(a,b) == 15);
}

// https://github.com/dlang/phobos/issues/11047
@safe pure nothrow unittest
{
enum ctfeLargeMultiplication = BigUint.mul(BigUint(ulong(1)) << ulong(33), BigUint(ulong(1)) << ulong(32));
}

// Remove leading zeros from x, to restore the BigUint invariant
inout(BigDigit) [] removeLeadingZeros(return scope inout(BigDigit) [] x) pure nothrow @safe
{
Expand Down
Loading