Move user flags to table

[brage-andreas]

No description provided.

[brage-andreas]

• Add Knight attendee plate #3192
• Add Exceptionally Distinguished attendee plate #3190
• Add attendee plates #3130
• Move user flags to table #3074 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Critical: Data Loss - The migration drops the flags column without migrating existing flag data. Any users who currently have flags assigned will lose them.

The migration should:

1. Create the new tables first
2. Migrate existing flag data to user_flag_link records
3. Only then drop the old column

Example migration logic needed:

-- Insert user_flag_link records for existing flags
INSERT INTO "user_flag_link" ("id", "user_id", "user_flag_id", "awarded_at")
SELECT 
  gen_random_uuid(),
  u.id,
  uf.id,
  u.updated_at
FROM "ow_user" u
CROSS JOIN LATERAL unnest(u.flags) flag_name
JOIN "user_flag" uf ON uf.name = flag_name;

Suggested change

	ALTER TABLE "ow_user" DROP COLUMN "flags";
	-- Migrate existing flag data to user_flag_link records
	INSERT INTO "user_flag_link" ("id", "user_id", "user_flag_id", "awarded_at")
	SELECT
	gen_random_uuid(),
	u.id,
	uf.id,
	u.updated_at
	FROM "ow_user" u
	CROSS JOIN LATERAL unnest(u.flags) flag_name
	JOIN "user_flag" uf ON uf.name = flag_name;
	ALTER TABLE "ow_user" DROP COLUMN "flags";

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Critical: Duplicate Flag Assignments - This method doesn't check if a flag is already assigned to the user before creating a new link. Since the database schema has no unique constraint on (userId, userFlagId), this will create duplicate userFlagLink records if called multiple times.

Fix by using upsert or checking for existence first:

async assignFlagToUser(handle, userId, flagName) {
  const flag = await handle.userFlag.findUnique({ where: { name: flagName } })
  if (!flag) throw new Error(`Flag ${flagName} not found`)
  
  const existing = await handle.userFlagLink.findFirst({
    where: { userId, userFlagId: flag.id }
  })
  
  if (!existing) {
    await handle.userFlagLink.create({
      data: {
        userId,
        userFlagId: flag.id,
        awardedAt: new Date(),
      },
    })
  }
}

Alternatively, add a unique constraint to the schema: @@unique([userId, userFlagId])

Suggested change

	async assignFlagToUser(handle, userId, flagName) {
	await handle.userFlagLink.create({
	data: {
	user: { connect: { id: userId } },
	userFlag: { connect: { name: flagName } },
	awardedAt: new Date(),
	},
	})
	},
	async assignFlagToUser(handle, userId, flagName) {
	const flag = await handle.userFlag.findUnique({ where: { name: flagName } })
	if (!flag) throw new Error(`Flag ${flagName} not found`)
	const existing = await handle.userFlagLink.findFirst({
	where: { userId, userFlagId: flag.id },
	})
	if (!existing) {
	await handle.userFlagLink.create({
	data: {
	userId,
	userFlagId: flag.id,
	awardedAt: new Date(),
	},
	})
	}
	},

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.