Add attendee plates#3130
Draft
brage-andreas wants to merge 2 commits into
Draft
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
April 25, 2026 14:02
a51fb8b to
b7b7b8d
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
April 25, 2026 14:02
dd6a738 to
2f9c807
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
April 25, 2026 15:22
b7b7b8d to
5109dcd
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
April 25, 2026 15:22
2f9c807 to
25e92dc
Compare
brage-andreas
changed the base branch from
move-user-flags-to-table
to
graphite-base/3130
April 27, 2026 16:25
brage-andreas
force-pushed
the
graphite-base/3130
branch
from
April 30, 2026 19:54
25e92dc to
98f3554
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
April 30, 2026 19:54
5109dcd to
7e26c61
Compare
brage-andreas
changed the base branch from
graphite-base/3130
to
move-user-flags-to-table
April 30, 2026 19:54
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
April 30, 2026 20:35
7e26c61 to
0d641ba
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 1, 2026 13:08
98f3554 to
ad2524e
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 1, 2026 13:08
0d641ba to
a20cad5
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 1, 2026 19:28
ad2524e to
fcdcb07
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
2 times, most recently
from
May 1, 2026 23:01
d1bcdb9 to
e371f68
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 2, 2026 16:58
8b99d17 to
3cfbcf7
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
2 times, most recently
from
May 3, 2026 17:03
05629b6 to
43420c7
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 3, 2026 17:04
43420c7 to
9eb10ed
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 3, 2026 17:10
3cfbcf7 to
4ca7774
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
3 times, most recently
from
May 3, 2026 22:41
dfd4ce1 to
2943375
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 3, 2026 22:41
2943375 to
e0fcc43
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 8, 2026 12:26
1d5e85b to
7b4a608
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 8, 2026 12:26
5b9cb4d to
5b4c3ad
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 14, 2026 17:24
1676261 to
4910b0a
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 19, 2026 10:45
750c53c to
510fdb9
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 19, 2026 21:58
1ee1fba to
537e5e6
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
2 times, most recently
from
May 19, 2026 23:17
177ec4e to
b65715d
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 19, 2026 23:17
537e5e6 to
c5f4db3
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
May 19, 2026 23:32
b65715d to
dbb84f0
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
2 times, most recently
from
May 21, 2026 17:19
9534f53 to
e0a6a39
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
2 times, most recently
from
May 23, 2026 16:02
3ffa09a to
f4ab617
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
May 25, 2026 16:56
9ee7c14 to
f851e77
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
2 times, most recently
from
May 25, 2026 22:03
af0f601 to
9daea53
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
June 11, 2026 19:59
9daea53 to
ae50086
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
June 14, 2026 12:11
0705dd4 to
4ec7e5b
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
June 14, 2026 12:11
ae50086 to
05ede9d
Compare
Comment on lines
+8
to
+9
| export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) { | ||
| const { largeIcon, smallIcons } = getAttendeeIcons(attendee) |
There was a problem hiding this comment.
Props smallIcons and largeIcon from PlateProps are not being destructured, causing them to be ignored. The component then re-computes these values instead of using the passed props. This is inconsistent with VanityVerifiedPlate which correctly uses the passed props.
export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) {
// Remove line 9: const { largeIcon, smallIcons } = getAttendeeIcons(attendee)The props are already computed in AttendeeList.tsx at line 19 and should be reused rather than recalculated.
Suggested change
| export function GenericPlate({ attendee, user, userSection: customUserSection, rightSection }: PlateProps) { | |
| const { largeIcon, smallIcons } = getAttendeeIcons(attendee) | |
| export function GenericPlate({ attendee, user, smallIcons, largeIcon, userSection: customUserSection, rightSection }: PlateProps) { | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
June 17, 2026 15:48
05ede9d to
ae1d0ce
Compare
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
June 17, 2026 15:48
4ec7e5b to
6eb1a5a
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
June 24, 2026 18:07
ae1d0ce to
bf7a587
Compare
brage-andreas
changed the base branch from
move-user-flags-to-table
to
graphite-base/3130
June 26, 2026 15:52
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
July 1, 2026 19:19
bf7a587 to
6c498ca
Compare
brage-andreas
force-pushed
the
graphite-base/3130
branch
from
July 1, 2026 19:19
00fd8d9 to
3e4873e
Compare
brage-andreas
changed the base branch from
graphite-base/3130
to
move-user-flags-to-table
July 1, 2026 19:19
brage-andreas
force-pushed
the
move-user-flags-to-table
branch
from
July 7, 2026 09:17
3e4873e to
f466c43
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
July 7, 2026 09:17
6c498ca to
07e5630
Compare
brage-andreas
force-pushed
the
add-attendee-plates
branch
from
July 11, 2026 16:46
07e5630 to
7e69129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.