Remove legacyCredential PAT usage from Arcade templates#16920
Open
missymessa wants to merge 1 commit into
Open
Remove legacyCredential PAT usage from Arcade templates#16920missymessa wants to merge 1 commit into
missymessa wants to merge 1 commit into
Conversation
The enable-internal-sources.yml template already handles DevDiv projects by using the 'dnceng-artifacts-feeds-read' federated service connection. Passing legacyCredential overrides this with PAT-based auth unnecessarily. This removes the PAT dependency (dn-bot-dnceng-artifact-feeds-rw) from publish-build-assets and post-build templates. Fixes AB#10143
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacyCredential PAT parameter from two enable-internal-sources.yml template invocations so DevDiv pipelines fall through to the federated dnceng-artifacts-feeds-read service connection auth path instead of using the dn-bot-dnceng-artifact-feeds-rw PAT.
Changes:
- Drop
legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw)from theenable-internal-sources.ymlcall inpost-build.yml. - Drop the DevDiv-conditional
legacyCredentialparameter block from theenable-internal-sources.ymlcall inpublish-build-assets.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/core-templates/post-build/post-build.yml | Removes PAT-based legacyCredential parameter so federated WIF auth is used. |
| eng/common/core-templates/job/publish-build-assets.yml | Removes DevDiv-only legacyCredential block so federated WIF auth is used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
legacyCredentialparameter fromenable-internal-sources.ymlcalls inpublish-build-assets.ymlandpost-build.yml. This eliminates the dependency on thedn-bot-dnceng-artifact-feeds-rwPAT for DevDiv pipeline feed authentication.How it works
The
enable-internal-sources.ymltemplate already has a built-in path for DevDiv projects that uses thednceng-artifacts-feeds-readfederated service connection (WIF-backed). WhenlegacyCredentialis passed, it overrides this modern auth path with PAT-based auth unnecessarily.By removing the parameter, DevDiv pipelines will now use the WIF service connection automatically.
Validation
dnceng-artifacts-feeds-readSC in DevDiv has been verified working (FIC configured, SC passes verification)Fixes AB#10143