JobMonitor: route warnings/errors through AzDO timeline issue logging and remove log emojis

[Copilot]

JobMonitor failures were not consistently emitted in a timeline-ingestible format, so key work item failure details could be missed in AzDO build timeline diagnostics. This change standardizes warning/error emission through prefixed logger helpers and applies it to failure-critical monitor paths.

• AzDO issue-prefix logging helpers

  • Added centralized warning/error helpers in JobMonitorRunner that prepend:
    • ##vso[task.logissue type=warning]
    • ##vso[task.logissue type=error]
  • Added matching error helper usage in Program for unhandled monitor exceptions.

• Failure paths now emit timeline issues

  • Failed work item console-link messages now emit as warnings (timeline-visible).
  • Final failed work-item summary, timeout reporting, cancellation failures, and non-monitor pipeline failure signaling now emit as errors/warnings via the helper path.

• Emoji cleanup for JobMonitor logs

  • Removed all emoji markers (including ❌) from JobMonitor log statements to reduce visual noise; AzDO timeline coloring and ##[warning]/##[error] rendering already provide sufficient visual prominence.

• Focused test updates

  • Updated JobMonitorRunnerTests assertions to verify warning/error prefixes are present for failed work-item and timeout/error logs.
  • Updated assertions that previously expected emoji-prefixed log text.
  • Ran targeted validation: ./eng/common/dotnet.sh test src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj --filter FullyQualifiedName~JobMonitorRunnerTests (47/47 passing).

private void LogWarning(string message)
    => _logger.LogWarning("{Prefix}{Message}", "##vso[task.logissue type=warning]", message);

private void LogError(string message)
    => _logger.LogError("{Prefix}{Message}", "##vso[task.logissue type=error]", message);

To double check:

• The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

[premun]

@mmitche, I think we should maybe remove the emojis? It's red enough:

[premun]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved by merging latest origin/main and fixing the conflict in JobMonitorRunner in commit e22c96477.

[premun]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved by merging latest origin/main and fixing the test conflicts in commit ba286eb.

[premun]

@copilot can you remove the emojis like ❌ from the log statements in the job monitor? Also make sure tests still pass

[premun]

@copilot can you remove the ❌ emojis from the error/warning log statements in the job monitor? Also make sure tests still pass

[Copilot]

@copilot can you remove the emojis like ❌ from the log statements in the job monitor? Also make sure tests still pass

Done in commit 2f142c9. I removed the emojis from JobMonitor log statements (including the ❌ warning/error lines) and updated the related assertions. I also ran JobMonitorRunnerTests (--filter FullyQualifiedName~JobMonitorRunnerTests), and they pass.

[Copilot]

Pull request overview

Standardizes JobMonitor warning/error logging so failures surface as Azure DevOps timeline issues via ##vso[task.logissue ...], and updates tests to assert the new prefixes on key failure paths.

Changes:

• Add centralized AzDO warning/error prefix helpers in JobMonitorRunner and route multiple failure paths through them.
• Update Program to emit unhandled exceptions via an AzDO-prefixed error helper.
• Update JobMonitorRunnerTests assertions to expect the new warning/error prefixes on timeout and failed work-item logs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/JobMonitorRunnerTests.cs	Updates assertions to expect AzDO task.logissue prefixes on timeout and failure logs.
src/Microsoft.DotNet.Helix/JobMonitor/Program.cs	Routes unhandled exception logging through an AzDO-prefixed error helper.
src/Microsoft.DotNet.Helix/JobMonitor/JobMonitorRunner.cs	Introduces AzDO warning/error helpers and uses them in failure/timeout/cancellation-related logging paths.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.