Add the reviewer skill checking if the Learn article Change waves is updated#13840
Draft
GangWang01 wants to merge 1 commit into
Draft
Add the reviewer skill checking if the Learn article Change waves is updated#13840GangWang01 wants to merge 1 commit into
GangWang01 wants to merge 1 commit into
Conversation
Contributor
🔍 Skill Validator Results
Summary
Full validator output```text Found 1 skill(s) [reviewing-msbuild-code] 📊 reviewing-msbuild-code: 220 BPE tokens [chars/4: 281] (compact ✓), 1 sections, 0 code blocks [reviewing-msbuild-code] ⚠ No code blocks — agents perform better with concrete snippets and commands. [reviewing-msbuild-code] ⚠ No numbered workflow steps — agents follow sequenced procedures more reliably. ✅ All checks passed (1 skill(s)) Found 1 agent(s) Validated 1 agent(s)✅ All checks passed (1 agent(s)) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s automated review guidance so that when documentation/wiki/ChangeWaves.md changes, reviewers are prompted to ensure the corresponding public Learn article about MSBuild Change Waves is kept in sync.
Changes:
- Added a docs-sync reminder to the
reviewing-msbuild-codeskill documentation. - Added a new ChangeWave-discipline checklist item to the
expert-revieweragent guidance to verify the Learn article is updated whenChangeWaves.mdchanges.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/skills/reviewing-msbuild-code/SKILL.md | Adds a docs-sync check note pointing reviewers to the Learn article when ChangeWaves.md changes. |
| .github/agents/expert-reviewer.agent.md | Extends the ChangeWave Discipline dimension with an explicit “verify Learn article updated” rule + checklist item. |
|
|
||
| Invoke `@expert-reviewer` for 24-dimension MSBuild code review. The agent contains the full methodology, principles, dimension rules with checklists, folder hotspot mapping, and 4-wave workflow. | ||
|
|
||
| The automated review includes a docs-sync check: when `documentation/wiki/ChangeWaves.md` changes, reviewers should flag if the corresponding Learn article is not updated: https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio. |
Comment on lines
+70
to
+77
| 4. If `../../documentation/wiki/ChangeWaves.md` is changed, verify the corresponding Learn article is also updated: `https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio`. | ||
|
|
||
| **CHECK — Flag if:** | ||
| - [ ] A behavioral change is not gated behind a ChangeWave | ||
| - [ ] The ChangeWave version number does not match the next release | ||
| - [ ] Only the enabled path is tested; no test for disabled/opt-out | ||
| - [ ] The ChangeWave is not documented in `../../documentation/wiki/ChangeWaves.md` | ||
| - [ ] `../../documentation/wiki/ChangeWaves.md` is changed but the Learn article `https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio` is not updated |
| - [ ] The ChangeWave version number does not match the next release | ||
| - [ ] Only the enabled path is tested; no test for disabled/opt-out | ||
| - [ ] The ChangeWave is not documented in `../../documentation/wiki/ChangeWaves.md` | ||
| - [ ] `../../documentation/wiki/ChangeWaves.md` is changed but the Learn article `https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio` is not updated |
JanProvaznik
requested changes
May 25, 2026
Member
JanProvaznik
left a comment
JanProvaznik
left a comment
There was a problem hiding this comment.
hm actually I don't think this should be done as part of each PR that add changewave behavior, rather as part of the release checklist. Could you add a step there and put guidance for updating the learn page to the release skill?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13811
Context
To keep the Learn article sync with documentation/wiki/ChangeWaves.md, add reviewer skill to check.