Skip to content

Add the reviewer skill checking if the Learn article Change waves is updated #13840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GangWang01 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Draft

Add the reviewer skill checking if the Learn article Change waves is updated #13840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/agents/expert-reviewer.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,14 @@ See `../../documentation/wiki/ChangeWaves.md` and `../../documentation/wiki/Chan
1. Use the correct ChangeWave version — must match the upcoming MSBuild release, not the current one
2. Test both enabled and disabled paths — `MSBuildDisableFeaturesFromVersion` opt-out must work.
3. Document the ChangeWave in error messages, specs, and the ChangeWaves tracking file.
4. If `../../documentation/wiki/ChangeWaves.md` is changed, verify the corresponding Learn article is also updated: `https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio`.

**CHECK — Flag if:**
- [ ] A behavioral change is not gated behind a ChangeWave
- [ ] The ChangeWave version number does not match the next release
- [ ] Only the enabled path is tested; no test for disabled/opt-out
- [ ] The ChangeWave is not documented in `../../documentation/wiki/ChangeWaves.md`
- [ ] `../../documentation/wiki/ChangeWaves.md` is changed but the Learn article `https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio` is not updated
Comment on lines +70 to +77

---

Expand Down
2 changes: 2 additions & 0 deletions .github/skills/reviewing-msbuild-code/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ description: "Reviews MSBuild code changes using a 24-dimension methodology. Act
# MSBuild Code Review

Invoke `@expert-reviewer` for 24-dimension MSBuild code review. The agent contains the full methodology, principles, dimension rules with checklists, folder hotspot mapping, and 4-wave workflow.

The automated review includes a docs-sync check: when `documentation/wiki/ChangeWaves.md` changes, reviewers should flag if the corresponding Learn article is not updated: https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=visualstudio.
Comment thread
GangWang01 marked this conversation as resolved.
Loading