feat: add validate_landmarks() for JSON and CSV landmark file validation#407
Closed
P-r-e-m-i-u-m wants to merge 1 commit intodreamlessx:mainfrom
Closed
feat: add validate_landmarks() for JSON and CSV landmark file validation#407P-r-e-m-i-u-m wants to merge 1 commit intodreamlessx:mainfrom
P-r-e-m-i-u-m wants to merge 1 commit intodreamlessx:mainfrom
Conversation
Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
Owner
|
Nice implementation @P-r-e-m-i-u-m — the This PR has a merge conflict though — likely from the other PRs that just merged. Can you rebase on latest main? git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseOnce the conflict is resolved and CI passes, I'll merge it. |
Owner
|
Closing — superseded by #420 which is a clean fresh PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402
Adds
validate_landmarks()utility to check landmark files before processing.Changes
landmarkdiff/validation.pyvalidate_landmarks(path)function supporting.jsonand.csvformatsValidationResultdataclass withvalid,errors,warnings,landmark_count,dimensions[0, 1]normalized or[0, image_size]pixel{"landmarks": [[x, y, z], ...], "confidence": [...]}or bare listx,yorx,y,zcolumns with optional header rowUsage