feat: add validate_landmarks() for JSON and CSV landmark file validation#420
Conversation
Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
|
Thanks @P-r-e-m-i-u-m — this is a much cleaner approach than #407! Good call making a fresh PR. The CI is failing on lint — quick fix: ruff check landmarkdiff/validation.py --fix
ruff format landmarkdiff/validation.py
git add -u && git commit -m "style: fix lint" && git pushOne style note: the private-prefixed imports ( Fix the lint and this is ready to merge! You can also close #407 since this replaces it. |
…ting Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
|
"Fixed lint — moved imports to top of file, switched to standard names (csv, json, math, dataclass, field), and fixed formatting. Ready for merge @dreamlessx |
|
Almost there! Lint rules pass now but the formatter still wants to reformat the file. Two separate steps: ruff check landmarkdiff/validation.py # lint rules (this passes now)
ruff format landmarkdiff/validation.py # formatting (this is what's failing)
git add -u && git commit -m "style: format validation.py" && git pushOne more push and it's green. |
Signed-off-by: 🄂ʏᴇᴅ 🄰ʙᴅᴜʟ 🄰ᴍᴀ🄝 ✧ <amanbaba9404522@gmail.com>
|
"Formatted with ruff format. Should be green now — ready for merge @dreamlessx |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
All CI checks pass -- the only failure is codecov/patch (coverage threshold), which isn't blocking. Merging now. Nice work @P-r-e-m-i-u-m, thanks for sticking with it through the lint iterations! |
|
Ready for merge @dreamlessx 👍" |
Closes #402
Adds
validate_landmarks()utility tolandmarkdiff/validation.pyto check landmark files before processing.Changes
landmarkdiff/validation.pyLandmarkValidationResultdataclass withvalid,errors,warnings,landmark_count,dimensionsvalidate_landmarks(path)supporting.jsonand.csvformats_parse_landmark_json()and_parse_landmark_csv()helpersUsage