Update renovate config#155
Conversation
📝 WalkthroughWalkthroughSimplifies the Renovate configuration by consolidating granular settings into a streamlined setup. Removes legacy groups, scheduling rules, custom managers, timezone settings, and other metadata. Enables automerge, dependencyDashboard, and pinDigests while preserving core functionality through reduced configuration complexity. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@renovate.json`:
- Around line 24-28: Summary: current group rule uses matchPackageNames: ["*"]
(groupName: "all", groupSlug: "all") which groups every dependency into one PR;
change it to safer grouping. Replace the wildcard group by creating targeted
groups instead (e.g., group by ecosystem or update type) by adding multiple
objects that use matchPackagePatterns or matchDepTypes/matchUpdateTypes (or
matchPackageNames with specific lists) so that runtime, dev, and
ecosystem-specific deps are split; ensure automerge/pr settings are applied
per-group as desired and remove or narrow the global "*" group to avoid blocking
all updates on a single failure.
- Around line 10-11: The config mixes Renovate matchers—use matchDepNames
consistently instead of matchPackageNames; replace occurrences of
"matchPackageNames": ["*"] with "matchDepNames": ["*"] (and ensure other rules
using "matchPackageNames" are updated similarly), keeping existing rule values
like ["php"] and ["node"] unchanged so all rules uniformly use matchDepNames.
| "matchDepNames": ["php"], | ||
| "matchManagers": ["composer"], |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🌐 Web query:
Renovate matchPackageNames vs matchDepNames deprecation
💡 Result:
matchDepNames is not deprecated in Renovate. It’s a supported matcher, and it’s documented as behaving like matchPackageNames but matching against depName instead of packageName. [1]
How to choose:
- Use
matchPackageNameswhen you want to match Renovate’s canonicalpackageName(the exact identifier Renovate uses to look up the dependency in a registry). [2] - Use
matchDepNameswhen you want to match the user-facingdepName(often the “pretty”/short name used in PR titles/branch names). [1][3]
Why this matters: depName and packageName are often the same, but not always (e.g., some ecosystems/managers expand packageName to a more specific identifier), so switching between the two can change what your rule matches. [3]
Sources:
[1] https://docs.renovatebot.com/configuration-options/ (packageRules.matchDepNames)
[2] https://docs.renovatebot.com/configuration-options/ (packageRules.matchPackageNames)
[3] https://docs.renovatebot.com/faq/ (depName vs packageName)
Use matchDepNames consistently throughout the configuration.
Both matchDepNames and matchPackageNames are supported matchers in Renovate, but they serve different purposes: matchDepNames matches user-facing dependency names, while matchPackageNames matches canonical package identifiers. The configuration mixes both—using matchDepNames for ["php"] and ["node"] (lines 10, 15) but matchPackageNames for ["*"] (line 25). For clarity and consistency with the existing rules, use matchDepNames throughout.
♻️ Proposed fix for consistency
{
- "matchPackageNames": ["*"],
+ "matchDepNames": ["*"],
"groupName": "all dependencies",
"groupSlug": "all"
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@renovate.json` around lines 10 - 11, The config mixes Renovate matchers—use
matchDepNames consistently instead of matchPackageNames; replace occurrences of
"matchPackageNames": ["*"] with "matchDepNames": ["*"] (and ensure other rules
using "matchPackageNames" are updated similarly), keeping existing rule values
like ["php"] and ["node"] unchanged so all rules uniformly use matchDepNames.
| { | ||
| "groupName": "GitHub Actions - All - Major, minor and patch", | ||
| "groupSlug": "github-actions-all-major-minor-patch", | ||
| "schedule": [ | ||
| "before 3am" | ||
| ], | ||
| "matchManagers": [ | ||
| "github-actions" | ||
| ], | ||
| "pinDigests": true | ||
| } | ||
| ], | ||
| "customManagers": [ | ||
| { | ||
| "customType": "regex", | ||
| "managerFilePatterns": [ | ||
| "/^docker-compose\\.yml$/" | ||
| ], | ||
| "matchStrings": [ | ||
| "IMAGE:\\s*\"?\\${(?:.*):-(?<depName>.*?):(?<currentValue>.*?)(?:\\@sha256:.*)?}\"?" | ||
| ], | ||
| "datasourceTemplate": "docker", | ||
| "versioningTemplate": "docker" | ||
| "matchPackageNames": ["*"], | ||
| "groupName": "all dependencies", | ||
| "groupSlug": "all" | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider the implications of grouping all dependencies.
Grouping all dependencies into a single PR (matchPackageNames: ["*"]) with automerge enabled means all minor/patch updates will be merged together. This simplifies management but:
- A single failing dependency could block all other updates.
- If issues arise post-merge, it's harder to identify which dependency caused the problem.
If this is the intended workflow for this repository, this is acceptable. Otherwise, consider grouping by ecosystem or update type.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@renovate.json` around lines 24 - 28, Summary: current group rule uses
matchPackageNames: ["*"] (groupName: "all", groupSlug: "all") which groups every
dependency into one PR; change it to safer grouping. Replace the wildcard group
by creating targeted groups instead (e.g., group by ecosystem or update type) by
adding multiple objects that use matchPackagePatterns or
matchDepTypes/matchUpdateTypes (or matchPackageNames with specific lists) so
that runtime, dev, and ecosystem-specific deps are split; ensure automerge/pr
settings are applied per-group as desired and remove or narrow the global "*"
group to avoid blocking all updates on a single failure.
|
Code coverage (GitHub Actions) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #155 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 11 11
Lines 163 163
========================================
Hits 143 143
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated renovate config via 🤠 RepoRanger.
Summary by CodeRabbit