-
-
Notifications
You must be signed in to change notification settings - Fork 0
Update renovate config #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,197 +1,30 @@ | ||
| { | ||
| "extends": [ | ||
| "config:recommended" | ||
| ], | ||
| "branchPrefix": "deps/", | ||
| "labels": [ | ||
| "Dependencies" | ||
| ], | ||
| "assignees": [], | ||
| "ignorePresets": [ | ||
| ":prHourlyLimit2" | ||
| ], | ||
| "extends": ["config:recommended"], | ||
| "automerge": true, | ||
| "rangeStrategy": "bump", | ||
| "timezone": "Australia/Melbourne", | ||
| "configMigration": true, | ||
| "enabledManagers": [ | ||
| "composer", | ||
| "npm", | ||
| "dockerfile", | ||
| "docker-compose", | ||
| "github-actions", | ||
| "custom.regex" | ||
| ], | ||
| "dependencyDashboard": true, | ||
| "pinDigests": true, | ||
| "branchPrefix": "deps/", | ||
| "packageRules": [ | ||
| { | ||
| "groupName": "PHP - Language version - Skipped to update manually", | ||
| "groupSlug": "php-language-version", | ||
| "matchDepNames": [ | ||
| "php" | ||
| ], | ||
| "matchManagers": [ | ||
| "composer" | ||
| ], | ||
| "matchDepNames": ["php"], | ||
| "matchManagers": ["composer"], | ||
| "enabled": false | ||
| }, | ||
| { | ||
| "groupName": "JavaScript - Language versions - Skipped to update manually", | ||
| "groupSlug": "js-language-versions", | ||
| "matchDepNames": [ | ||
| "node", | ||
| "yarn" | ||
| ], | ||
| "matchManagers": [ | ||
| "npm" | ||
| ], | ||
| "matchDepNames": ["node", "yarn"], | ||
| "matchManagers": ["npm"], | ||
| "enabled": false | ||
| }, | ||
| { | ||
| "groupName": "PHP - All packages - Major - Skipped to update manually", | ||
| "groupSlug": "php-all-major", | ||
| "matchDatasources": [ | ||
| "packagist" | ||
| ], | ||
| "matchFileNames": [ | ||
| "composer.json" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "major" | ||
| ], | ||
| "enabled": false, | ||
| "matchPackageNames": [ | ||
| "/.*/" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "PHP - All packages except core - Minor and patch", | ||
| "groupSlug": "php-all-except-core-minor-patch", | ||
| "matchDatasources": [ | ||
| "packagist" | ||
| ], | ||
| "matchFileNames": [ | ||
| "composer.json" | ||
| ], | ||
| "separateMinorPatch": false, | ||
| "schedule": [ | ||
| "before 2am on Sunday" | ||
| ], | ||
| "matchPackageNames": [ | ||
| "/.*/", | ||
| "!drupal/core-composer-scaffold", | ||
| "!drupal/core-project-message", | ||
| "!drupal/core-recommended", | ||
| "!drupal/core-dev" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "PHP - Drupal core - Minor and patch", | ||
| "groupSlug": "php-drupal-core-minor-patch", | ||
| "matchFileNames": [ | ||
| "composer.json" | ||
| ], | ||
| "schedule": [ | ||
| "before 2am" | ||
| ], | ||
| "matchDatasources": [ | ||
| "packagist" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "patch", | ||
| "minor" | ||
| ], | ||
| "matchDepNames": [ | ||
| "drupal/core-composer-scaffold", | ||
| "drupal/core-project-message", | ||
| "drupal/core-recommended", | ||
| "drupal/core-dev" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "JavaScript - Non-root packages - Skipped to update manually", | ||
| "groupSlug": "js-non-root", | ||
| "matchDatasources": [ | ||
| "npm" | ||
| ], | ||
| "matchFileNames": [ | ||
| "!package.json" | ||
| ], | ||
| "enabled": false, | ||
| "matchPackageNames": [ | ||
| "/.*/" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "JavaScript - All packages - Major - Skipped to update manually", | ||
| "groupSlug": "js-all-major", | ||
| "matchDatasources": [ | ||
| "npm" | ||
| ], | ||
| "matchFileNames": [ | ||
| "package.json" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "major" | ||
| ], | ||
| "enabled": false, | ||
| "matchPackageNames": [ | ||
| "/.*/" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "JavaScript - All packages - Minor and patch", | ||
| "groupSlug": "js-all-minor-patch", | ||
| "matchDatasources": [ | ||
| "npm" | ||
| ], | ||
| "matchFileNames": [ | ||
| "package.json" | ||
| ], | ||
| "separateMinorPatch": false, | ||
| "schedule": [ | ||
| "before 2am on Sunday" | ||
| ], | ||
| "matchPackageNames": [ | ||
| "/.*/" | ||
| ] | ||
| }, | ||
| { | ||
| "groupName": "Container images - All - Major, minor and patch", | ||
| "groupSlug": "container-images-all-major-minor-patch", | ||
| "matchFileNames": [ | ||
| ".docker/**" | ||
| ], | ||
| "schedule": [ | ||
| "before 3am" | ||
| ], | ||
| "matchManagers": [ | ||
| "dockerfile", | ||
| "docker-compose", | ||
| "custom.regex" | ||
| ] | ||
| "matchManagers": ["npm", "composer"], | ||
| "matchUpdateTypes": ["major"], | ||
| "enabled": false | ||
| }, | ||
| { | ||
| "groupName": "GitHub Actions - All - Major, minor and patch", | ||
| "groupSlug": "github-actions-all-major-minor-patch", | ||
| "schedule": [ | ||
| "before 3am" | ||
| ], | ||
| "matchManagers": [ | ||
| "github-actions" | ||
| ], | ||
| "pinDigests": true | ||
| } | ||
| ], | ||
| "customManagers": [ | ||
| { | ||
| "customType": "regex", | ||
| "managerFilePatterns": [ | ||
| "/^docker-compose\\.yml$/" | ||
| ], | ||
| "matchStrings": [ | ||
| "IMAGE:\\s*\"?\\${(?:.*):-(?<depName>.*?):(?<currentValue>.*?)(?:\\@sha256:.*)?}\"?" | ||
| ], | ||
| "datasourceTemplate": "docker", | ||
| "versioningTemplate": "docker" | ||
| "matchPackageNames": ["*"], | ||
| "groupName": "all dependencies", | ||
| "groupSlug": "all" | ||
| } | ||
|
Comment on lines
24
to
28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider the implications of grouping all dependencies. Grouping all dependencies into a single PR (
If this is the intended workflow for this repository, this is acceptable. Otherwise, consider grouping by ecosystem or update type. 🤖 Prompt for AI Agents |
||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🌐 Web query:
Renovate matchPackageNames vs matchDepNames deprecation💡 Result:
matchDepNamesis not deprecated in Renovate. It’s a supported matcher, and it’s documented as behaving likematchPackageNamesbut matching againstdepNameinstead ofpackageName. [1]How to choose:
matchPackageNameswhen you want to match Renovate’s canonicalpackageName(the exact identifier Renovate uses to look up the dependency in a registry). [2]matchDepNameswhen you want to match the user-facingdepName(often the “pretty”/short name used in PR titles/branch names). [1][3]Why this matters:
depNameandpackageNameare often the same, but not always (e.g., some ecosystems/managers expandpackageNameto a more specific identifier), so switching between the two can change what your rule matches. [3]Sources:
[1] https://docs.renovatebot.com/configuration-options/ (packageRules.matchDepNames)
[2] https://docs.renovatebot.com/configuration-options/ (packageRules.matchPackageNames)
[3] https://docs.renovatebot.com/faq/ (depName vs packageName)
Use
matchDepNamesconsistently throughout the configuration.Both
matchDepNamesandmatchPackageNamesare supported matchers in Renovate, but they serve different purposes:matchDepNamesmatches user-facing dependency names, whilematchPackageNamesmatches canonical package identifiers. The configuration mixes both—usingmatchDepNamesfor ["php"] and ["node"] (lines 10, 15) butmatchPackageNamesfor ["*"] (line 25). For clarity and consistency with the existing rules, usematchDepNamesthroughout.♻️ Proposed fix for consistency
{ - "matchPackageNames": ["*"], + "matchDepNames": ["*"], "groupName": "all dependencies", "groupSlug": "all" }🤖 Prompt for AI Agents